Opened 13 years ago

Closed 13 years ago

Last modified 21 months ago

#8723 closed patch

Sort the list of engines

Reported by: jvprat Owned by: sev-
Priority: normal Component: GUI
Keywords: Cc:
Game:

Description

This patch sorts all the lists of engines alphabetically, like it was done some time ago with the configure help options list.

The main advantadge of this would be for people working on new engines outside of the ScummVM tree, because it would prevent the current conflicts to the "add engine" patches when a new engine is added upstream, because the context would be much less prone to change.

Ticket imported from: #1800767. Ticket imported from: patches/828.

Attachments (2)

sort_engines.patch (11.8 KB ) - added by jvprat 13 years ago.
Patch to sort the engines alphabetically in the source
sort_engines2.patch (11.5 KB ) - added by jvprat 13 years ago.
Sort engines leaving SCUMM and variants at the top

Download all attachments as: .zip

Change History (11)

by jvprat, 13 years ago

Attachment: sort_engines.patch added

Patch to sort the engines alphabetically in the source

comment:1 by lordhoto, 13 years ago

Looks good. I would always set SCUMM to the top though, since it's the 'main' and oldest engine of ScummVM. SCUMM is set to the top of our credits too.

comment:2 by jvprat, 13 years ago

That would be reasonable if it's always done the same way. For example: always begin with scumm, scumm7-8, he, and follow with the rest alphabetically. When you decide the rules I can rework the patch.

by jvprat, 13 years ago

Attachment: sort_engines2.patch added

Sort engines leaving SCUMM and variants at the top

comment:3 by jvprat, 13 years ago

I'm attaching a second version based on my previous comment. File Added: sort_engines2.patch

comment:4 by fingolfin, 13 years ago

I agree with lordhoto here. Rest is fine (but I didn't have a chance to look at the patch yet, I am just talking about the general idea here :). Eugene?

comment:5 by fingolfin, 13 years ago

Owner: set to sev-

comment:6 by fingolfin, 13 years ago

Looked at the patch, it seems fine to me. So if Eugene agrees, we can commit this.

comment:7 by sev-, 13 years ago

Indeed, the patch is good. Thanks for your submission, committed as is.

comment:8 by sev-, 13 years ago

Status: newclosed

comment:9 by digitall, 21 months ago

Component: GUI
Note: See TracTickets for help on using tickets.