Opened 12 years ago

Closed 12 years ago

Last modified 7 months ago

#8722 closed patch

small "unknown control change byte 32" patch

Reported by: SF/megath Owned by: fingolfin
Priority: normal Component: Audio: MT32
Keywords: Cc:
Game: Touche

Description

Controller number 32 means "bank select" as 0, but interpret 'value' in a slightly different way.
Anyway, bank selection is not supported by scummvm, so just skip warning about unknown control change byte.

Ticket imported from: #1800085. Ticket imported from: patches/827.

Attachments (1)

cc32.patch (537 bytes) - added by SF/megath 12 years ago.

Download all attachments as: .zip

Change History (6)

Changed 12 years ago by SF/megath

Attachment: cc32.patch added

comment:1 Changed 12 years ago by fingolfin

Hi, please elaborate a bit: What is this patch for? Why should we add it? Where (in which game, which part of it) can one test it? Etc.

comment:2 Changed 12 years ago by SF/megath

Just to remove useless warning about thing which never will be added (changing midi bank).
Scummvm does not moan about control byte 0, why should it moan about byte 32 ? (it's the same command as 0)
The last time I saw it, it was "Touche" game.

comment:3 Changed 12 years ago by fingolfin

Thanks, added to SVN.

comment:4 Changed 12 years ago by fingolfin

Owner: set to fingolfin
Status: newclosed

comment:5 Changed 7 months ago by digitall

Component: Audio: MT32
Game: Touche
Summary: small "unknown control change byte 32" patch small "unknown control change byte 32" patch
Note: See TracTickets for help on using tickets.