Opened 13 years ago

Closed 13 years ago

Last modified 12 months ago

#8569 closed patch

BASS: Missing music volume text in v303 french menu

Reported by: SF/njoly Owned by: fingolfin
Priority: normal Component: Engine: Sky
Keywords: Cc:
Game: Beneath a Steel Sky

Description

Hi,

I noticed that BASS v303, with french language, miss
the text `Volume de musique' (like v368) in menu;
instead it prints `NULL frame number'.

This is not really a ScummVM problem as the original
game when played with DosBox show exactly the same.
However, i think this needs to be fixed.

I made the attached patch to work around this problem
by adding another string to the Text::_patchedMessages
array.

Hope this helps,
Regards.

njoly@lanfeust [~/games]> uname -a
NetBSD lanfeust.sis.pasteur.fr 4.99.1 NetBSD 4.99.1
(LANFEUST) #3: Mon Aug 21 11:33:48 CEST 2006
njoly@lanfeust.sis.pasteur.fr:/local/src/NetBSD/obj/amd64/sys/arch/amd64/compile/LANFEUST
amd64
njoly@lanfeust [~/games]> scummvm -v
Using configuration file: /home/njoly/.scummvmrc
ScummVM 0.10.0svn (Aug 21 2006 14:51:16)
Features compiled in: zLib
njoly@lanfeust [~/games]> scummvm -p sky sky
Using configuration file: /home/njoly/.scummvmrc
Looking for sky
Trying to start game 'Beneath a Steel Sky'
Found BASS version v0.0303 (1413 dnr entries)
[...]

Ticket imported from: #1543932. Ticket imported from: patches/674.

Attachments (2)

scummvm-skyfrmenu.diff (1.1 KB ) - added by SF/njoly 13 years ago.
french music volume text menu fix
skymenu.png (25.9 KB ) - added by SF/njoly 13 years ago.
French menu with missing text for music volume

Download all attachments as: .zip

Change History (13)

by SF/njoly, 13 years ago

Attachment: scummvm-skyfrmenu.diff added

french music volume text menu fix

by SF/njoly, 13 years ago

Attachment: skymenu.png added

French menu with missing text for music volume

comment:1 by fingolfin, 13 years ago

Owner: set to joostp

comment:2 by fingolfin, 13 years ago

joost, does this look good enough to be added?

comment:3 by fingolfin, 13 years ago

Owner: changed from joostp to lavosspawn

comment:4 by fingolfin, 13 years ago

Robert, maybe you have an oppinion and can handle this patch?

comment:5 by fingolfin, 13 years ago

Owner: changed from lavosspawn to SF/olki

comment:6 by fingolfin, 13 years ago

Trying with yet another BASS maintainer: Olki, I think you are pretty much inactive these days, but maybe you still can tell me whether it's OK to commit this or not... ?

comment:7 by SF/olki, 13 years ago

That part of the sky engine was not written by me, so my guess to whether or not it is okay to commit that patch is as good as yours. However, the patch looks fairly trivial to me, and has few chances of really messing something up badly without anybody noticing it immediately.

comment:8 by SF/olki, 13 years ago

Owner: SF/olki removed

comment:9 by fingolfin, 13 years ago

OK, so I just added the patch. I figure that if anything is broken by it, somebody will eventually complain loudly :)

comment:10 by fingolfin, 13 years ago

Owner: set to fingolfin
Status: newclosed

comment:11 by digitall, 12 months ago

Component: Engine: Sky
Game: Beneath a Steel Sky
Note: See TracTickets for help on using tickets.