Opened 17 years ago

Closed 17 years ago

#854 closed defect (fixed)

ZAK256: Shadowed text (end credits)

Reported by: SF/hibernatus Owned by: fingolfin
Priority: normal Component: Engine: SCUMM
Keywords: Cc:
Game: Zak McKracken

Description

Played from scratch with: ScummVM 0.4.2cvs Built on Jun 7 2003 16:04:04

In the end credits, shadowed text is not supported, and the colors are wrong. zakend_1.gif: original engine zakend_2.gif: scummvm

Other less important differences: - Some colors seem a little darker in the background picture. And it isn't because of the gif conversion. - A line of text is shifted by one pixel.

Ticket imported from: #750779. Ticket imported from: bugs/854.

Attachments (3)

zak256.s09 (58.4 KB ) - added by SF/hibernatus 17 years ago.
Pull the switch. For 0.4.2cvs 6/7/3
zakend_1.gif (36.5 KB ) - added by SF/hibernatus 17 years ago.
End credits: Original engine
zakend_2.gif (34.2 KB ) - added by SF/hibernatus 17 years ago.
End credits: ScummVM

Download all attachments as: .zip

Change History (10)

by SF/hibernatus, 17 years ago

Attachment: zak256.s09 added

Pull the switch. For 0.4.2cvs 6/7/3

by SF/hibernatus, 17 years ago

Attachment: zakend_1.gif added

End credits: Original engine

by SF/hibernatus, 17 years ago

Attachment: zakend_2.gif added

End credits: ScummVM

comment:1 by SF/hibernatus, 17 years ago

The shadow looks wierd but that's because it's made by adding one pixel to the right and one pixel to the bottom, instead of one pixel to the lower right.

comment:2 by fingolfin, 17 years ago

Nice, at least now we know how that part of it is supposed to look like =)

Regarding the colors: the scripts do contain different color values. But for some reasons those don't reach the display (or rather the text looks as if it is drawn in the color of its shadow). This could be yet another palette problem.

As for the shadow: would be trivial to draw one; but how do we know whether to draw a shadow or not? Does Zak256 use text shadows in any other place?

comment:3 by SF/hibernatus, 17 years ago

The color number tells whether to display the shadow or not. My guess is "if (color & 0x80)", because color & 0x7F shows the right colors.

comment:4 by SF/hibernatus, 17 years ago

I forgot to say: I'm 100% sure the color number is what makes the shadow appear because i tested it in the original engine. BTW, the end credits are the only place where you can see shadowed text.

comment:5 by fingolfin, 17 years ago

I put a partial fix into CVS (was really trivial). It draws the text in correct colors now, and with a shadow. However, the shadow color seems to be wrong (it's hardcoded to be black right now). I am not sure whether there is a single fixed text shadow color; or if it is maybe derived from the text color; or set by some opcode.

Regarding the different colors in the background: no idea about them; but if you think it's worth a bug report, please file a separate one

The line of text which is shifted one pixel: well, ScummVM does center the text properly; the original engine doesn't. Personally I find ScummVM looks superior there.

comment:6 by SF/hibernatus, 17 years ago

I checked in zak.exp and it's always color 8.

comment:7 by fingolfin, 17 years ago

Owner: set to fingolfin
Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.