Opened 19 years ago

Closed 19 years ago

Last modified 5 years ago

#8438 closed patch (invalid)

small fix for findObjectInRoom

Reported by: SF/albeu Owned by: fingolfin
Priority: normal Component: Engine: SCUMM
Version: Keywords:
Cc: Game:


Setting the mouse cursor from a non fl object located in the current room fail. This is due to a bug in findObjectInRoom. At the start of this function an if block handle the case of alredy loaded fl objects. However the current test just assume that any local object will be an fl object. The attached patch fix the problem by just checking that fl_object_index is set.

Ticket imported from: #1222246. Ticket imported from: patches/543.

Attachments (1)

scummvm-findInRoomFix.diff (689 bytes ) - added by SF/albeu 19 years ago.

Download all attachments as: .zip

Change History (6)

by SF/albeu, 19 years ago

Attachment: scummvm-findInRoomFix.diff added


comment:1 by fingolfin, 19 years ago

Component: --Unset--
Summary: [PATCH] small fix in findObjectInRoomsmall fix for findObjectInRoom

comment:2 by fingolfin, 19 years ago

The attached patch doesn't fix the problem, it just avoids it.

I commited a proper fix to CVS.

comment:3 by fingolfin, 19 years ago

Owner: set to fingolfin
Resolution: invalid
Status: newclosed

comment:4 by SF/albeu, 19 years ago

Thanks for the care. I just wanted to confirm that your fix is working as expected.

comment:5 by digitall, 5 years ago

Component: Engine: SCUMM
Note: See TracTickets for help on using tickets.