Opened 15 years ago

Closed 15 years ago

Last modified 17 months ago

#8439 closed patch

fix gcc4 virtual functions non-virtual destructor warnings

Reported by: SF/awjb Owned by: fingolfin
Priority: normal Component: Ports
Keywords: Cc:
Game:

Description

Apply against current cvs. There are no warnings any more... ok non related to this anyway... whats left for me is this:

scumm/gfx.cpp: In member function ‘void Scumm::ScummEngine::ditherCGA(byte*, int, int, int, int, int) const’: scumm/gfx.cpp:625: warning: operation on ‘ptr’ may be undefined sky/logic.cpp: In member function ‘uint16 Sky::Logic::script(uint16, uint16)’: sky/logic.cpp:1340: warning: operation on ‘scriptData’ may be undefined ./common/list.h: In member function ‘int Saga::Scene::IHNMStartProc()’: ./common/list.h:49: warning: ‘firstScene$sceneDescription’ is used uninitialized in this function ./common/list.h: In member function ‘int Saga::Scene::ITEStartProc()’: ./common/list.h:49: warning: ‘firstScene$sceneDescription’ is used uninitialized in this function

Ticket imported from: #1224631. Ticket imported from: patches/544.

Attachments (1)

scummvm-gcc4-vf-nvd.patch (1.2 KB ) - added by SF/awjb 15 years ago.
vf-nvd patch against current cvs

Download all attachments as: .zip

Change History (8)

by SF/awjb, 15 years ago

Attachment: scummvm-gcc4-vf-nvd.patch added

vf-nvd patch against current cvs

comment:1 by fingolfin, 15 years ago

Owner: set to sev-

comment:2 by fingolfin, 15 years ago

Commited, thanks. I fixed the warning in gfx.cpp (the code was fishy indeed), and submitted a bug for sky/logic.cpp (the code looks wrong, too).

The last two warnings are for SAGA; Eugene, can you take a look at those?

comment:3 by sev-, 15 years ago

Just fixed. Andreas, please, test it.

comment:4 by SF/awjb, 15 years ago

The one in sky/logic.cpp:1340 I still get with the cvs checkout from a couple of minutes ago the other ones are gone :)

comment:5 by fingolfin, 15 years ago

Owner: changed from sev- to fingolfin
Status: newclosed

comment:6 by fingolfin, 15 years ago

Great. The sky bug has been fixed now, too.

comment:7 by digitall, 17 months ago

Component: Ports
Note: See TracTickets for help on using tickets.