Opened 15 years ago

Closed 14 years ago

Last modified 2 years ago

#8434 closed patch

Disable overlay scaling

Reported by: sev- Owned by: sev-
Priority: normal Component: GUI
Keywords: Cc:


This patch effectively kills overlay scaling. Since now our GUI is autoscaled, there is no more need to do it. Also it removes --force-1x-overlay option.

Ticket imported from: #1214784. Ticket imported from: patches/539.

Attachments (2)

disable-overlay-scaling.v1.diff.bz2 (6.7 KB ) - added by sev- 15 years ago.
v1 of the patch
mpeg-scale.diff (12.4 KB ) - added by eriktorbjorn 15 years ago.
Patch against a June 4 CVS snapshot

Download all attachments as: .zip

Change History (9)

by sev-, 15 years ago

v1 of the patch

comment:1 by sev-, 15 years ago

In v1 ot the patch GUI doesn't process resolution change which sometimes leads to unusable state.

comment:2 by fingolfin, 15 years ago

To clarify this patch: Right now, there *is* a need for the overlay to be autoscaled. The GUI currently *can't* rescale itself on the fly. So before we integrate this patch, we first have to restructure the GUI code to be able to adapt to resolution changes on the fly.

comment:3 by fingolfin, 15 years ago

Summary: Autoresize of overlayDisable overlay scaling

by eriktorbjorn, 15 years ago

Attachment: mpeg-scale.diff added

Patch against a June 4 CVS snapshot

comment:4 by eriktorbjorn, 15 years ago

Since the MPEG player (ab)uses the overlay to be able to draw 16-bit graphics, we'll need to add scaling to that too. I'm attaching a preliminary patch for that.

It only implements basic 2x and 3x scaling, not anti-aliasing. But frankly I doubt anyone will notice the difference. (Except for scaling the subtitles in BS2. It may be worth the trouble to use AdvMame there.)

It does not handle resolution changes during playback. I'll add that once we've decided how to handle it in the GUI.

The patch also tries to make the player a bit smarter when playing movies that do not cover the entire screen: it only updates that area of the screen, rather than the whole thing. This may cause glitches if the screen isn't properly cleared before the cutscene begins, but if so we can fix that later.

comment:5 by sev-, 14 years ago

Owner: set to sev-
Status: newclosed

comment:6 by sev-, 14 years ago

Heavily modified by LordHoto, tuned by sev and committed.

Eriktorbjorn's patch is applied as is.

comment:7 by digitall, 2 years ago

Component: GUI
Note: See TracTickets for help on using tickets.