Opened 15 years ago

Closed 15 years ago

Last modified 17 months ago

#8433 closed patch (outdated)

fc4/gcc4/x86_64

Reported by: SF/awjb Owned by: fingolfin
Priority: normal Component: Port: Linux
Keywords: Cc:
Game:

Description

Hi, I package scummvm for rpm.livna.org and had some trouble building 0.7.1 for x86_64 there. Attached is my patch which allows to compile it. Maybe this is of use for you...

-Andreas

Ticket imported from: #1211838. Ticket imported from: patches/538.

Attachments (1)

scummvm-x86_64.patch (1.1 KB ) - added by SF/awjb 15 years ago.

Download all attachments as: .zip

Change History (8)

by SF/awjb, 15 years ago

Attachment: scummvm-x86_64.patch added

comment:1 by fingolfin, 15 years ago

The patch for iMuse isn't necessary with current CVS.

As for the other two patches, I am concerned about the portability of intptr_t. Does 'long' work, too?

comment:2 by SF/awjb, 15 years ago

Hm, I guess it will work but is not really portable... As of C99 intptr_t and uintptr_t are to be used for casting int pointers... (nice how I learned that from those nice helping people on fedora-extras-commits ^^). So from my pov and the things I looked up those two will be portable... long would not really be portable outside the x86_64 scope... just my 2 cents...

comment:3 by fingolfin, 15 years ago

I am fully aware that intptr_t is part of C99. But many of our target systems aren't C++ compliant. First off, C99 is a C standard, and we target C++, second, many of the C++ compilers we have to support do not even implement C++ properly, and lastly, many compilers/libs out there aren't even close to fully supporting C99 (if they even try to...)

Using 'long', while not compatible with 64 bit system and DOS, should work even on those systems...

comment:4 by SF/awjb, 15 years ago

Don't get me wrong: long will probably do the trick and (thanks for the insight) under the given circumstances be the best choice if you have to 'work around' borken compilers and other things... it was just for fc4/gcc4/x86_64 that {,u}intptr_t was the best choice I could come up with. Go ahead an use long...

Thanks for the response anyway and taking the time to fix these things... :)

comment:5 by fingolfin, 15 years ago

All the issues reported here should be fixed in CVS, I hope.

comment:6 by fingolfin, 15 years ago

Owner: set to fingolfin
Resolution: outdated
Status: newclosed

comment:7 by digitall, 17 months ago

Component: Port: Linux
Note: See TracTickets for help on using tickets.