Opened 15 years ago

Closed 15 years ago

Last modified 23 months ago

#8432 closed patch

Warning Windows users about the known "play from CD" bug

Reported by: eriktorbjorn Owned by: eriktorbjorn
Priority: normal Component: Port: Win32
Keywords: Cc:
Game:

Description

When looking at discussion forums - both our own and other LucasArts-related ones - it's depressing to see how often the "Room X not in Y" problem comes up. This is almost certainly the known bug where playing a game with CD audio tracks from the CD causes ScummVM to crash.

Since this bug has been known for ages, I assume that we don't have any way to work around it. We can, however, issue a warning message to the user. That's what this patch does.

I don't know if this is the cleanest way of doing it, so it should be viewed as a proof-of-concept. It's quite possible that we need to add the same check for the Goblins engine, since that too uses CD audio tracks for some games.

Ticket imported from: #1208299. Ticket imported from: patches/537.

Attachments (1)

cd-warning.diff (2.9 KB ) - added by eriktorbjorn 15 years ago.
Patch against a May 25 CVS snapshot

Download all attachments as: .zip

Change History (11)

by eriktorbjorn, 15 years ago

Attachment: cd-warning.diff added

Patch against a May 25 CVS snapshot

comment:1 by SF/kaminari, 15 years ago

I'll take this opportunity to ask a newbie question: is there any explanation why this bug only occurs on Windows? I know a fair number of emulators under Win32 (mainly of Japanese systems like PC-88, PC-98, FM-Towns, PC Engine, Megadrive, etc) which are able to switch from audio tracks to data tracks without crashing. Why does that occur to ScummVM? Is it really a Windows bug, or maybe related to SDL? Sorry, I don't quite understand this.

comment:2 by eriktorbjorn, 15 years ago

I have no idea. All I know is that it's been listed as a known bug for as long as I can remember, and this is the best workaround I can come up with.

comment:3 by fingolfin, 15 years ago

Travis, do you know more about the causes of this issue?

comment:4 by fingolfin, 15 years ago

Owner: set to Kirben

comment:5 by Kirben, 15 years ago

It is a bug in Windows 2000/XP, not sure about earlier Windows versions. The problem is getting data off the CD, while CD audio is still playing. Try playing back any audio track on a CD and then copying a large file off that CD, you will get problems. An error or the CD audio just stops for long periods.

I have not seen the bug mentioned outside of ScummVM though, I can't seem to find any mention of it in the Microsoft Knowledge Base.

comment:6 by eriktorbjorn, 15 years ago

So is it a good or bad idea to add this kind of warning message?

comment:7 by fingolfin, 15 years ago

Erik, I guess it's the best we can do at this time, so feel free to add it.

Nevertheless, I still think it would be good if we confirmed that this is a Windows XP bug and that no workaround exists. I am surprised that there is no knowledge base article about this; but then again, dual Audio/Data CDs aren't that common, and modern games do not use audio CD tracks, so maybe only very few people ever notice this problem ?

comment:8 by eriktorbjorn, 15 years ago

Ok, I've applied the patch.

comment:9 by eriktorbjorn, 15 years ago

Owner: changed from Kirben to eriktorbjorn
Status: newclosed

comment:10 by digitall, 23 months ago

Component: Port: Win32
Note: See TracTickets for help on using tickets.