#8435 closed patch
Encoder parameters for BUN and SAN encoders
| Reported by: | eriktorbjorn | Owned by: | eriktorbjorn |
|---|---|---|---|
| Priority: | normal | Component: | Tools |
| Version: | Keywords: | ||
| Cc: | Game: |
Description
I haven't really had the time to test this patch, but it should allow the user to specify encoder parameters to the BUN and SAN encoders, just like with the other encoding programs.
As a side effect, it also changes the default encoding parameters to the same as for the other encoders.
Ticket imported from: #1217438. Ticket imported from: patches/540.
Attachments (1)
Change History (10)
by , 19 years ago
| Attachment: | compress-settings.diff added |
|---|
comment:1 by , 19 years ago
| Owner: | set to |
|---|
comment:2 by , 19 years ago
| Owner: | changed from to |
|---|
comment:3 by , 19 years ago
That patch not only modify bundle compress code. Changes for bundle code looks ok for me, but i'm not familiar with other tools code. Fingolfin ?
comment:4 by , 19 years ago
To clarify, the main reason the patch modifies the other tools slightly as well is that currently the process_*_parms() functions in compress.c expect to be able to call showhelp() if the parsing fails. This function is supposed to be defined in whatever tool is using the functions.
I wasn't able to figure out how to get this to work when the tool was written in C++ instead of C, so I changed the functions to return 1 for success and 0 for failure, and let the tools call showhelp() themselves.
comment:5 by , 19 years ago
| Owner: | changed from to |
|---|
comment:6 by , 19 years ago
i didn't noticed that you submited patch at first time, i thought that was someone outside of dev team. Code changes for bundle compression are ok from my point.
comment:7 by , 19 years ago
| Status: | new → closed |
|---|
comment:8 by , 19 years ago
In that case, I'll apply the patch. If something breaks, it can be dealt with (that's what development versions are for, right? ;-). I just wanted to make sure there were no general objections to it.
comment:9 by , 6 years ago
| Component: | → Tools |
|---|
Patch against a June 8 CVS snapshot