Opened 15 years ago

Closed 15 years ago

Last modified 2 years ago

#8435 closed patch

Encoder parameters for BUN and SAN encoders

Reported by: eriktorbjorn Owned by: eriktorbjorn
Priority: normal Component: Tools
Keywords: Cc:
Game:

Description

I haven't really had the time to test this patch, but it should allow the user to specify encoder parameters to the BUN and SAN encoders, just like with the other encoding programs.

As a side effect, it also changes the default encoding parameters to the same as for the other encoders.

Ticket imported from: #1217438. Ticket imported from: patches/540.

Attachments (1)

compress-settings.diff (13.1 KB ) - added by eriktorbjorn 15 years ago.
Patch against a June 8 CVS snapshot

Download all attachments as: .zip

Change History (10)

by eriktorbjorn, 15 years ago

Attachment: compress-settings.diff added

Patch against a June 8 CVS snapshot

comment:1 by eriktorbjorn, 15 years ago

Owner: set to aquadran

comment:2 by aquadran, 15 years ago

Owner: changed from aquadran to fingolfin

comment:3 by aquadran, 15 years ago

That patch not only modify bundle compress code. Changes for bundle code looks ok for me, but i'm not familiar with other tools code. Fingolfin ?

comment:4 by eriktorbjorn, 15 years ago

To clarify, the main reason the patch modifies the other tools slightly as well is that currently the process_*_parms() functions in compress.c expect to be able to call showhelp() if the parsing fails. This function is supposed to be defined in whatever tool is using the functions.

I wasn't able to figure out how to get this to work when the tool was written in C++ instead of C, so I changed the functions to return 1 for success and 0 for failure, and let the tools call showhelp() themselves.

comment:5 by aquadran, 15 years ago

Owner: changed from fingolfin to eriktorbjorn

comment:6 by aquadran, 15 years ago

i didn't noticed that you submited patch at first time, i thought that was someone outside of dev team. Code changes for bundle compression are ok from my point.

comment:7 by eriktorbjorn, 15 years ago

Status: newclosed

comment:8 by eriktorbjorn, 15 years ago

In that case, I'll apply the patch. If something breaks, it can be dealt with (that's what development versions are for, right? ;-). I just wanted to make sure there were no general objections to it.

comment:9 by digitall, 2 years ago

Component: Tools
Note: See TracTickets for help on using tickets.