Opened 17 years ago

Closed 17 years ago

Last modified 17 months ago

#8264 closed patch

Possible fix for bug #778060

Reported by: eriktorbjorn Owned by: eriktorbjorn
Priority: normal Component: Engine: SCUMM
Keywords: Cc:
Game: Day of the Tentacle

Description

This patch seems to fix bug #778060 ("DOTT: Subtitle drawing glitch").

The problem is that when the game is showing the room with Laverne's Chron-O-John virtscr[0].xstart is displayed, and it isn't properly re-initialized until after Bernard's text message has been displayed.

The scripts make use of a temporary savegame to get back to Bernard's room, so if I change loadState() to call cameraMoved() for all games, and not just for GF_NEW_CAMERA games as is currently the case, then it works.

I think this is a safe change to make, but I'm not sure enough to commit it without a second opinion, because I don't know why it was restricted to only some games to begin with.

Ticket imported from: #778442. Ticket imported from: patches/369.

Attachments (1)

dott-text-glitch.diff (457 bytes ) - added by eriktorbjorn 17 years ago.
Patch against a July 26 CVS snapshot

Download all attachments as: .zip

Change History (5)

by eriktorbjorn, 17 years ago

Attachment: dott-text-glitch.diff added

Patch against a July 26 CVS snapshot

comment:1 by fingolfin, 17 years ago

I don't see how it could cause problems either, but that's doesn't mean a bit :-)

Best approach might be once again to compare this with disassembly... or just apply it to the trunk, and we'll wait for the regression reports to arrive :-)

comment:2 by eriktorbjorn, 17 years ago

Owner: set to eriktorbjorn
Status: newclosed

comment:3 by eriktorbjorn, 17 years ago

I've applied the patch to the trunk.

comment:4 by digitall, 17 months ago

Component: Engine: SCUMM
Game: Day of the Tentacle
Note: See TracTickets for help on using tickets.