#8263 closed patch
BASS: CD intro fixes
| Reported by: | eriktorbjorn | Owned by: | joostp |
|---|---|---|---|
| Priority: | normal | Component: | Engine: Sky |
| Version: | Keywords: | ||
| Cc: | Game: | Beneath a Steel Sky |
Description
This patch attempts to fix a few issues with the BASS CD intro.
1. It no longer crashes for me. I'm still not 100% sure of what was causing the crash. Maybe it was freeing a buffer before the mixer was done with it, or something like that.
2. Silence the annoying popping at the beginning of every voice-over. This is a bit of a hack. I guess we really ought to use _skySound to play the sound instead of calling playRaw() directly...
3. The job of looping background sound effects has been offloaded to the mixer. The sounds don't loop quite seamlessly, but at least there are less gaps this way.
4. I've made a few changes to which background sounds play where. I'm not sure about the result, but it sounds right to me.
Ticket imported from: #776225. Ticket imported from: patches/368.
Attachments (1)
Change History (6)
by , 21 years ago
| Attachment: | sky-intro.diff added |
|---|
comment:1 by , 21 years ago
| Owner: | set to |
|---|
comment:2 by , 21 years ago
Assigning to joostp since he was the one who found the bug. Feel free to reassign.
comment:3 by , 21 years ago
Applying this. the crash has been fixed and the crackling sound also doesn't loop longer than it should anymore, other than that, it sounds right, but it's hard to compare..
Btw. Looping wasn't seamless in the original interpreter either, perhaps the sfx-sample in question can be blamed for this.
comment:4 by , 21 years ago
| Status: | new → closed |
|---|
comment:5 by , 5 years ago
| Component: | → Engine: Sky |
|---|---|
| Game: | → Beneath a Steel Sky |
Patch against a July 22 CVS snapshot