Opened 17 years ago

Closed 17 years ago

Last modified 12 months ago

#8191 closed patch

CMI: Object line (slightly incomplete)

Reported by: eriktorbjorn Owned by: fingolfin
Priority: normal Component: Engine: SCUMM
Keywords: Cc:
Game: Monkey Island 3

Description

This is a first attempt at enabling the CMI "object
line", i.e. the line at the bottom of the screen that
shows which object the mouse cursor is over, the action
you are about to perform, etc.

Actually, the current behaviour is more or less
correct, given that the "Show object line" setting is
false. But it should be true by default. To make it so,
the patch hacks the readRegistry() opcode to yield true
for the "Object Names" case. I don't like this, but it
will have to do for now.

The next part of the puzzle is to implement
removeBlastTexts() so that it actually removes the
blast texts instead of simply clearing the blast text
queue.

The remaining changes are mostly cosmetic. I had to
change decodeParseString() slightly to keep it from
silencing talk sounds on mouse-overs. Also, I've
demoted the "Failed finding voice" message from a
warning to a debug message.

The "Show object line" setting will still be false for
old savegames, but even the old behaviour may benefit
from the blast text change. Eventually we should be
able to change the setting from within the game, but
that options screen doesn't work yet.

The thing that remains is to fix the case when using
one object on another. Apparently we don't handle the
translation of PU_M001 and PU_M002 correctly. The
object line is handled by script 39.

Ticket imported from: #712493. Ticket imported from: patches/296.

Attachments (2)

cmi-object-line.diff (3.0 KB ) - added by eriktorbjorn 17 years ago.
Patch against a March 30 CVS snapshot
cmi-object-line2.diff (4.3 KB ) - added by eriktorbjorn 17 years ago.
Patch against a March 31 CVS snapshot

Download all attachments as: .zip

Change History (5)

by eriktorbjorn, 17 years ago

Attachment: cmi-object-line.diff added

Patch against a March 30 CVS snapshot

by eriktorbjorn, 17 years ago

Attachment: cmi-object-line2.diff added

Patch against a March 31 CVS snapshot

comment:1 by eriktorbjorn, 17 years ago

This second version of the patch adds a hack that seems to
make the object line work in the English version, at least.
I don't know about other languages though.

By the way, with the blast text changes the end credits
work. (Except for a crash that happens sometimes, but that's
another patch.) So if it's applied, the CMI issues page
should be updated.

comment:2 by fingolfin, 17 years ago

Owner: set to fingolfin
Status: newclosed

comment:3 by digitall, 12 months ago

Component: Engine: SCUMM
Game: Monkey Island 3
Note: See TracTickets for help on using tickets.