Opened 17 years ago

Closed 17 years ago

Last modified 13 months ago

#8190 closed patch

CMI: Fix for inventory bug

Reported by: eriktorbjorn Owned by: fingolfin
Priority: normal Component: Engine: SCUMM
Keywords: Cc:
Game: Monkey Island 3

Description

I patch seems to fix the inventory bug mentioned on the
CMI issues page, where the game gets confused about
which is the last object in the inventory chest. The
problem happens because the findBlastObject() opcode
returns the wrong object number, which I believe is
because the loop starts at one object past the end of
the blast object queue.

(I have a savegame that demonstrates this, but since
it's a bit large I'm not attaching it unless someone
asks me to.)

Ticket imported from: #708384. Ticket imported from: patches/295.

Attachments (1)

cmi-inventory-fix.diff (590 bytes ) - added by eriktorbjorn 17 years ago.
Patch against a March 21 CVS snapshot

Download all attachments as: .zip

Change History (7)

by eriktorbjorn, 17 years ago

Attachment: cmi-inventory-fix.diff added

Patch against a March 21 CVS snapshot

comment:1 by fingolfin, 17 years ago

Yup this definitely is a off-by-one bug. Good catch.

comment:2 by fingolfin, 17 years ago

Owner: set to fingolfin
Status: newclosed

comment:3 by fingolfin, 17 years ago

Yup this definitely is a off-by-one bug. Good catch.

comment:4 by fingolfin, 17 years ago

I guess the corresponding item can now be removed from comi.xml ?

comment:5 by eriktorbjorn, 17 years ago

I certainly hope so.

comment:6 by digitall, 13 months ago

Component: Engine: SCUMM
Game: Monkey Island 3
Note: See TracTickets for help on using tickets.