Opened 18 years ago

Closed 18 years ago

Last modified 2 years ago

#8009 closed patch

Loom sound fixes

Reported by: eriktorbjorn Owned by: SF/ender
Priority: normal Component: Engine: SCUMM
Keywords: Cc:
Game: Loom

Description

This is an attempt to fix two slight sound problems in Loom.

The first problem is that the sound doesn't stop if, for instance, I hit Escape to skip a cutscene. In these cases Loom will try to play a sound with offset and delay both being 0. Applying this part of the fix shouldn't break anything else, since it's within a Loom-specific piece of code.

The second problem is that during the final confrontation with Chaos, Loom will cause stopSound(0) to be called. Since current_cd_sound is 0 at this time, this will cause the CD (or MP3) to stop. I don't think Loom ever does anything that causes current_cd_sound to be set, and anyway 0 is used to indicate that there is no current CD sound. This part of the fix, I'm less certain about.

Ticket imported from: #594921. Ticket imported from: patches/114.

Attachments (1)

loomsound.diff (1.3 KB ) - added by eriktorbjorn 18 years ago.
Experimental sound fixes

Download all attachments as: .zip

Change History (5)

by eriktorbjorn, 18 years ago

Attachment: loomsound.diff added

Experimental sound fixes

comment:1 by eriktorbjorn, 18 years ago

I forgot to mention: The patch is against an August 13 CVS snapshot.

comment:2 by SF/ender, 18 years ago

Owner: set to SF/ender
Status: newclosed

comment:3 by SF/ender, 18 years ago

Also looks good. It didn't break anything I tested, and if anyone ELSE sees an objection they can rewrite the fix another way.

comment:4 by digitall, 2 years ago

Component: Engine: SCUMM
Game: Loom
Note: See TracTickets for help on using tickets.