Opened 12 years ago

Closed 12 years ago

Last modified 13 months ago

#7615 closed enhancement (outdated)

TOOLS (compress_queen): add --best to FLAC parameters

Reported by: SF/clemty Owned by: fingolfin
Priority: normal Component: Tools
Keywords: Cc:
Game:

Description

using current svn tools with flac 1.2.1 on Win32

flac has a switch "--best" which creates smallest possible files

currently the ScummVM tools (at least compress_queen) do not set this; the difference for FOTAQ English is ~2mb:

97.636.137 queen.1c (--best)
99.633.565 queen.1c (default settings)

I believe this option should be set; the additional time it takes to compress the files is in my opinion negligible on current hardware

not sure if this affects other tools as well

Ticket imported from: #1873131. Ticket imported from: feature-requests/431.

Change History (9)

comment:1 by fingolfin, 12 years ago

Side note: This is already possible in the gsoc2007-toolsgui branch. We should merge it RSN!

comment:2 by jvprat, 12 years ago

Now the branch is merged. Does it work? Is it enough or you wanted to propose --best as the default setting?

comment:3 by SF/clemty, 12 years ago

yes, I meant setting --best as default setting - I could achieve the results I posted in the original tracker item without recompiling (just setting it manually via cmdline was enough) - but usually endusers don't bother fiddling with the settings

sorry if my post was ambiguous in that aspect

comment:4 by fingolfin, 12 years ago

Owner: set to fingolfin
Resolution: outdated
Status: newclosed

comment:5 by fingolfin, 12 years ago

Actually, we already use compression level 8 as default, which is equivalent to --best. So, this FR is redundant, it seems ;-)

comment:6 by SF/clemty, 12 years ago

how can this request be redundant if I get two different results with default settings and manually setting --best?

comment:7 by fingolfin, 12 years ago

Did you actually retest with the latest version of the tools? Because compress_queen used to *not* use our common compression framework, so it did indeed not default to compression level 8. But the current compress_queen *does* do that. In fact there the "--best" option is equivalent to the default settings.

There is only one thing we modify with regards to the usual --best parameter to flac: Namely, we change the blocksize from 4608 to 1152. This *might* make a difference, you could try it via the "-b" option. I am not quite sure why we change the default blocksize, actually... Maybe that changed in some FLAC version.

comment:8 by SF/clemty, 12 years ago

seems I misunderstood you

feel free to close it then

comment:9 by digitall, 13 months ago

Component: Tools
Note: See TracTickets for help on using tickets.