#6688 closed defect (fixed)
UBUNTU: Build failure due to Unity Taskbar
| Reported by: | SF/c-korn | Owned by: | |
|---|---|---|---|
| Priority: | normal | Component: | Port: Linux |
| Version: | Keywords: | build | |
| Cc: | Game: |
Description
Hello,
trying to compile scummvm 1.7.0 for the Ubuntu gaming site playdeb,net there is this build error: g++ -MMD -MF "backends/taskbar/unity/.deps/unity-taskbar.d" -MQ "backends/taskbar/unity/unity-taskbar.o" -MP -Wall -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 -g -ansi -W -Wno-unused-parameter -Wno-empty-body -pedantic -Wno-long-long -O2 -Wuninitialized -Wno-long-long -Wno-multichar -Wno-unknown-pragmas -Wno-reorder -Wpointer-arith -Wcast-qual -Wshadow -Wnon-virtual-dtor -Wwrite-strings -fno-exceptions -fcheck-new -DHAVE_CONFIG_H -DRELEASE_BUILD -DSDL_BACKEND -DPOSIX -DDATA_PATH=\"/usr/share/scummvm\" -DPLUGIN_DIRECTORY=\"/usr/lib/scummvm\" -DENABLE_SCUMM=STATIC_PLUGIN -DENABLE_SCUMM_7_8 -DENABLE_HE -DENABLE_AGI=STATIC_PLUGIN -DENABLE_AGOS=STATIC_PLUGIN -DENABLE_AGOS2 -DENABLE_CGE=STATIC_PLUGIN -DENABLE_CINE=STATIC_PLUGIN -DENABLE_COMPOSER=STATIC_PLUGIN -DENABLE_CRUISE=STATIC_PLUGIN -DENABLE_DRACI=STATIC_PLUGIN -DENABLE_DRASCULA=STATIC_PLUGIN -DENABLE_DREAMWEB=STATIC_PLUGIN -DENABLE_GOB=STATIC_PLUGIN -DENABLE_GROOVIE=STATIC_PLUGIN -DENABLE_HOPKINS=STATIC_PLUGIN -DENABLE_HUGO=STATIC_PLUGIN -DENABLE_KYRA=STATIC_PLUGIN -DENABLE_LOL -DENABLE_EOB -DENABLE_LURE=STATIC_PLUGIN -DENABLE_MADE=STATIC_PLUGIN -DENABLE_MOHAWK=STATIC_PLUGIN -DENABLE_MORTEVIELLE=STATIC_PLUGIN -DENABLE_NEVERHOOD=STATIC_PLUGIN -DENABLE_PARALLACTION=STATIC_PLUGIN -DENABLE_PEGASUS=STATIC_PLUGIN -DENABLE_QUEEN=STATIC_PLUGIN -DENABLE_SAGA=STATIC_PLUGIN -DENABLE_IHNM -DENABLE_SCI=STATIC_PLUGIN -DENABLE_SKY=STATIC_PLUGIN -DENABLE_SWORD1=STATIC_PLUGIN -DENABLE_SWORD2=STATIC_PLUGIN -DENABLE_TEENAGENT=STATIC_PLUGIN -DENABLE_TINSEL=STATIC_PLUGIN -DENABLE_TOLTECS=STATIC_PLUGIN -DENABLE_TONY=STATIC_PLUGIN -DENABLE_TOON=STATIC_PLUGIN -DENABLE_TOUCHE=STATIC_PLUGIN -DENABLE_TSAGE=STATIC_PLUGIN -DENABLE_TUCKER=STATIC_PLUGIN -DENABLE_VOYEUR=STATIC_PLUGIN -DENABLE_WINTERMUTE=STATIC_PLUGIN -I. -I. -I./engines -I/usr/include/SDL -D_GNU_SOURCE=1 -D_REENTRANT -I/usr/include/freetype2 -c backends/taskbar/unity/unity-taskbar.cpp -o backends/taskbar/unity/unity-taskbar.o backends/taskbar/unity/unity-taskbar.cpp:33:19: fatal error: unity.h: No such file or directory #include
Ticket imported from: bugs/6688.
Attachments (2)
Change History (16)
comment:1 by , 10 years ago
| Summary: | fatal error: unity.h: No such file or directory → UBUNTU: Build failure due to Unity Taskbar |
|---|
by , 10 years ago
| Attachment: | build-log.txt.gz added |
|---|
comment:2 by , 10 years ago
comment:3 by , 10 years ago
c-korn:See this message: ##718164 "FTBFS: Makefile:87: *** You need to run ./configure before you can run make".
It looks like you have not run the configure script. If you have, please attach the config.mk and config.h as this will help work out why the unity path has not been detected.
Setting this bug to pending. If it is not updated within 14 days, it will automatically be closed.
comment:4 by , 10 years ago
| Resolution: | → worksforme |
|---|---|
| Status: | new → pending |
comment:5 by , 10 years ago
The part of configure checking for unity is very broken. If anyone using unity wants to submit a patch, please do.
comment:6 by , 10 years ago
| Resolution: | worksforme |
|---|---|
| Status: | pending → new |
comment:7 by , 10 years ago
This should make it a little... less broken: https://github.com/scummvm/scummvm/commit/04767e7b2a826f94e1daf259264f7f86cc515983
comment:10 by , 10 years ago
Yes, that was the problem (and that's basically what I did, plus a few other things that were weird).
I suppose it's fixed by now - it seemingly compiles fine and sans spurious warnings with libunity.
by , 10 years ago
| Attachment: | alt-patch.diff added |
|---|
comment:11 by , 10 years ago
Attaching the patch from Christoph Korn in the bug report - Thanks for your work!
comment:12 by , 10 years ago
| Keywords: | build added |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
comment:13 by , 10 years ago
OK, since the issue has been resolved, this bug report can now be closed.
Thanks finding the issue, and fixing it!
comment:14 by , 6 years ago
| Component: | → Port: Linux |
|---|
Attaching the build log referred to earlier as external services may become inaccesssible before a developer gets time to look at this.