Opened 10 years ago

Closed 3 years ago

#6687 closed defect (worksforme)

SCI: Quitting while MIDI plays causes hanging notes

Reported by: lordhoto Owned by: raziel-
Priority: normal Component: Engine: SCI
Version: Keywords: midi
Cc: Game: King's Quest 6

Description

ScummVM git 09cb06d1fa75f51a9967a15d96a5360b990afec4 Linux/amd64 gcc 4.9.0 Kings Quest 6 CD Windows

SCI does not send note off commands when quitting ScummVM while MIDI plays. When using a hardware MIDI sythesizer like my Roland SC-55 this causes currently active notes to hang.

Ticket imported from: bugs/6687.

Change History (9)

comment:1 by SF/natedavis82, 10 years ago

I have not noticed this on my SC-55. Does it happen every time you quit?

EDIT: I always hit CTRL-F5 and then click quit. I don't use the built-in quit function in KQ6. Is that how you quit too?

comment:2 by m-kiewitz, 9 years ago

Component: Engine: SCI

comment:3 by csnover, 6 years ago

Keywords: midi added
Owner: set to csnover

comment:4 by digitall, 5 years ago

Owner: csnover removed

comment:5 by digitall, 5 years ago

Game: King's Quest 6

comment:6 by ZvikaZ, 4 years ago

Hi @lordhoto .
Please check if https://github.com/ZvikaZ/scummvm/tree/z_midi_reset is solving this.

comment:7 by ZvikaZ, 4 years ago

Or even better,

https://github.com/ZvikaZ/scummvm.git , branch z_midi_reset_v3

comment:8 by raziel-, 4 years ago

ScummVM 2.2.0git (Jul 15 2020 10:24:49)
Features compiled in: Vorbis FLAC MP3 RGB zLib MPEG2 Theora AAC A/52 FreeType2 FriBiDi JPEG PNG cloud (servers, local)

I can not confirm this behaviour (anymore?).

Using Yamaha MU90 hardware here and no hanging notes with either KQ6 in-game quit or ScummVM's launcher quit (I tried some more SCI games and none show this behaviour).
I do remember having similar problems years back, but at some point they were fixed.

King's Quest VI: Heir Today, Gone Tomorrow (CD/Windows/English)

AmigaOS4 - PPC - BE - SDL

comment:9 by ZvikaZ, 3 years ago

Owner: set to raziel-
Resolution: worksforme
Status: newclosed

Well, the original reporter has lost interest, and it works for @raziel-.
Closing.

Note: See TracTickets for help on using tickets.