#6399 closed defect (fixed)
LOL : Crash when subtitles displayed
| Reported by: | SF/alxtr1bal | Owned by: | athrxx |
|---|---|---|---|
| Priority: | normal | Component: | Engine: Kyra |
| Version: | Keywords: | ||
| Cc: | Game: | Lands of Lore |
Description
Port : Dingux Scummvm 1.6 Lands of Lore CD French DOS
This crash appears only in the French CD version on the dingux, it's working well on the PC in French CD Version. It crashes every time i bump into a wall when the subtitle is displayed (for example : 'You cannot go this way')
crash Log : ./scummvm.bin: libc/misc/ctype/ctype.c: 281:tolower: Assertion '((((unsigned int)((c) -0)) <= ((127*2+1) - 0)) || ((c) == (-1)))' Failed
I recompiled with latest git sources, it's the same thing.
Ticket imported from: #3614957. Ticket imported from: bugs/6399.
Change History (7)
comment:1 by , 11 years ago
| Summary: | Crash when subtitles displayed → LOL : Crash when subtitles displayed |
|---|
comment:2 by , 11 years ago
comment:3 by , 11 years ago
It works, no more crashes.
Well , i don't know why, i have a problem with Write permissions to save a game now... In fact i'm using the dingux port on the gcw zero ...
comment:5 by , 11 years ago
| Owner: | set to |
|---|
comment:6 by , 11 years ago
I've committed the fix as proposed by wjp, since it seems to work fine for all versions (including Japanese).
comment:7 by , 11 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Since you're able to recompile sources, could you test a possible fix?
In engines/kyra/text_rpg.cpp, try replacing the line
char a = tolower(_ctrl[1]);
by
char a = tolower((unsigned char)_ctrl[1]);