Opened 14 years ago
Closed 13 years ago
#5386 closed defect (fixed)
AGI LSL1: TAB stops working after restart
| Reported by: | eriktorbjorn | Owned by: | bluegr |
|---|---|---|---|
| Priority: | high | Component: | Engine: AGI |
| Version: | Keywords: | ||
| Cc: | Game: | Leisure Suit Larry 1 |
Description
Current 1.2.0 branch English version of the game (1.00 1987-06-01, 5.25"/3.5"/DOS/English, according to the detector)
This one's easy to reproduce: Start the game, andswer the questions, and type "restart" (or walk into a dark alley and let the game restart on its own). The TAB key no longer brings up the inventory. It seems the "game controllers" are reset on restart, but this game never recreates them. (I tried Space Quest 2, and the bug didn't happen there.)
Ticket imported from: #3074570. Ticket imported from: bugs/5386.
Attachments (1)
Change History (10)
comment:1 by , 14 years ago
comment:2 by , 14 years ago
This bug does not seem to happen in NAGI. (http://github.com/sonneveld/nagi)
comment:3 by , 14 years ago
Unlike ScummVM, NAGI doesn't appear to ever clear the controllers list, except in nagi_init(), which appears to only be called once. If cmd_set_key() fails to find a free slot, it just silently ignores it.
ScummVM's cmd_set_key() also ignores attempts to overflow the list, but prints a warning.
comment:4 by , 14 years ago
Assuming I understood the problem correctly, the patch I just attached should fix the problem. It doesn't work exactly like how I think NAGI works, but...
comment:6 by , 14 years ago
| Owner: | set to |
|---|---|
| Priority: | normal → high |
comment:8 by , 13 years ago
Fixed in r81fdf2c, by applying eriktorbjorn's patch and checking against NAGI
comment:9 by , 13 years ago
| Owner: | changed from to |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
I forgot to mention: The bug does not happen with the original interpreter in DOSBox.