Opened 18 years ago

Closed 18 years ago

#459 closed defect (wontfix)

ZAK256: Graphics messed up

Reported by: fingolfin Owned by: fingolfin
Priority: high Component: Engine: SCUMM
Keywords: Cc:
Game: Zak McKracken

Description

Since Pawel/aquadran made some changes on the October 31st, Zak256 graphics are messed up after loading a save game. I posted a message about this to scummvm-devel but apparently nobody read it.

This is quite serious. When I load a game, the screen graphics become partially garbled, and this effect is not going away, i.e. permanent.

Ticket imported from: #608849. Ticket imported from: bugs/459.

Change History (8)

comment:1 by SF/trinity78, 18 years ago

maybe releated to #600287 ???

comment:2 by fingolfin, 18 years ago

Just to clarify this, I am not fully sure that it was one of aquadran changes, but he did change a lot of stuff related to the size of the game window, and there were a couple other buglets introduced by this, too (e.g. I just fixed one in actor.cpp). It's possible that some other change broke this, maybe even mine, however, I only noticed this breakage after I returned from a one week absence, so I don't think that's too likely.

comment:3 by SF/ender, 18 years ago

Cannot replicate on i386/Linux.

Endian related? Please provide a saved game and further details. Does this happen in ALL rooms?

Are you using a graphics scaler, fullscreen or windowed, display resolution, ecetra?

Please follow the bug submission guidelines, Fingolfin :)

comment:4 by SF/ender, 18 years ago

Oh I see. This appears to be a problem with older saved games, the format has changed somewhere.

New games do not exhibit this problem. As we already have another patch to apply which will break saved games, I say we apply it, break the saved game format, and live with it. :)

comment:5 by fingolfin, 18 years ago

Well, it is quite bad then that something sneaked in which breaks all old games in Zak256 :-/ This isn't supposed to happen, I'd still like to know what causes this.

In any case, if we change save game formats, we should first think about which changes we all need. There are some marked in savload.cpp, and there is at least one patch on the patch tracker which requires a save game format change, too.

comment:6 by SF/ender, 18 years ago

Well, generally we can keep compatability with the old games by increasing the VER in saveload.cpp

However I think the savegame system really needs to be rewritten to be more modular. Any takers?

(btw, this change is some odd phantom thing somewhere. What I'm assuming is that SOMEWHERE we still had a 320x200 array. By changing all the width/height values in ScummVM to be dynamic, this array became 320x240. So basically, it's actually a BUGFIX that broke it. But we can't track down which of the variables it was)

comment:7 by fingolfin, 18 years ago

Owner: set to fingolfin
Resolution: wontfix
Status: newclosed

comment:8 by fingolfin, 18 years ago

I tried tracking it down anyway, but with not much success. I close this as WONTFIX as it's probably not worth the effort to change this (esp. since only one game is affected).

As for rewriting the save game system: I am all for it. I'll put some notes/suggestions on that onto our TODO web page.

Note: See TracTickets for help on using tickets.