Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#4528 closed defect (fixed)

KQ3: Game Crash When Leaving Tavern as Fly

Reported by: SF/maplesyrup Owned by: SF/buddha_
Priority: normal Component: Engine: AGI
Keywords: Cc:
Game: King's Quest 3

Description

When you are the fly in King's Quest III for the Amiga and you try to leave the tavern, ScummVM crashes with the message "Assertion failed: v->numloops >=n, file engines/agi/view.cpp, line 286"

I used the Amiga version of King's Quest III from Back to the Roots on Windows XP with ScummVM 1.0.0pre043189 (Aug 10, 2009 10:03:04)

Ticket imported from: #2835581. Ticket imported from: bugs/4528.

Attachments (1)

kq3-amiga.001 (3.7 KB ) - added by SF/maplesyrup 11 years ago.
Save game of Gwydion as a fly in the tavern

Download all attachments as: .zip

Change History (5)

by SF/maplesyrup, 11 years ago

Attachment: kq3-amiga.001 added

Save game of Gwydion as a fly in the tavern

comment:1 by SF/buddha_, 11 years ago

Actually it seems it always dies with that assertion if you fly straight up or straight down when as a fly but pressing left, right or any diagonal direction doesn't make it crash.

Probably something to do with what AGI version we're using for the game as Amiga AGI versions do not map directly to PC AGI versions but we're still trying to map them.

Checked the back2roots version of KQ3 Amiga under WinUAE and at least v20 = 5 in it so it doesn't use GF_OLDAMIGAV20 so at least that's not the problem.

comment:2 by SF/buddha_, 11 years ago

Owner: set to SF/buddha_
Resolution: fixed
Status: newclosed

comment:3 by SF/buddha_, 11 years ago

Fixed in trunk by r43414, in branch-1-0-0 by r43415:

Made the game detection entry choose 0x3149 for AGI version instead of the previously used 0x3086. Seems to fix this bug but additionally causes ESC to pause the game instead of accessing the menu (Trying the original game under WinUAE shows that ESC pauses the game in the original too though). Menu can be accessed with mouse as was in the original too.

I'm not certain but for this fix to be effective one may have to redetect the used game entry for KQ3 Amiga in the launcher (Or it may work without the redetection, as I said, I'm not sure).

Some thoughts about the fix:

The used Amiga AGI version in the original is AGI 2.333 but because we don't exactly know how they compare with PC AGI versions we simply try to choose some PC AGI version number and hope for the best. Thus this is a bit experimental, hopefully nothing else breaks in the game.

On the positive side changing the used AGI version number for a single game detection entry should not affect other games and thus is a very local code change.

comment:4 by SF/buddha_, 11 years ago

Maple Syrup reported the game completable now and that the fix worked without needing to redetect the game entry in the launcher.

Note: See TracTickets for help on using tickets.