Opened 11 years ago

Closed 11 years ago

Last modified 6 years ago

#3860 closed defect (fixed)

DW: german CD version MD5

Reported by: SF/egore Owned by:
Priority: normal Component: Engine: Tinsel
Keywords: detection Cc:
Game: Discworld

Description

The data from my original CD was not recognized. The attached patch adds support for this.

Ticket imported from: #2048383. Ticket imported from: bugs/3860.

Attachments (3)

tinsel-german.patch (1.0 KB ) - added by SF/egore 11 years ago.
tinsel-4flags.patch (1.2 KB ) - added by fingolfin 11 years ago.
Patch for detecting the 4FLAGS version
tinsel-multiflags.patch (13.7 KB ) - added by fingolfin 11 years ago.
Enhanced patch which enables language selection

Download all attachments as: .zip

Change History (18)

by SF/egore, 11 years ago

Attachment: tinsel-german.patch added

comment:1 by SF/egore, 11 years ago

Of course it only the second part of the patch ... :-)

comment:2 by fingolfin, 11 years ago

Can you please provide some details on this version, like: Does it contain german voice overs? The file size of english.smp seems to indicate that.

The patch in this form won't be applied -- like, we deliberately do not use the MD5 for the english.smp files, to avoid major slowdownd incurred by computing those. But don't worry about providing a new patch, all we need are the file sizes and MD5s anyway :).

comment:3 by fingolfin, 11 years ago

Owner: set to fingolfin
Summary: Tinsel german CD supportDW: german CD version MD5

comment:4 by SF/egore, 11 years ago

The game is the german version of Discworld 1. It contains only english audio files. Subtitles are provided in 4 different text files:

271514 28. Feb 1995 french.txt 261734 28. Feb 1995 german.txt 237774 28. Feb 1995 italian.txt 234618 28. Feb 1995 spanish.txt

The game itself is shipped with the german manual. If you need any further details, just let me know.

BTW: Good job on getting tinsel working!

comment:5 by fingolfin, 11 years ago

Hm, so strictly speaking, it is not a german version -- it's the english version together with subtitles for four extra languages. The manual is after all not part of the game... In fact we already have an entry matching your release, only that it will detect it as "english" version.

So, detection fails for you, I gather? Can you tell me the exact output ScummVM prints to the console?

comment:6 by SF/egore, 11 years ago

No, detection works fine. But the detected version defaults to english which is not available on this disc. I guess it's some kind of a "european" disc I got. For the following tests I reverted the patch. This is the output when starting the game with english set as language:

User picked target 'dw' (gameid 'tinsel')... Looking for a plugin supporting this gameid... Tinsel Engine Starting 'Tinsel engine game' Cannot find file english.txt!

This is the output when using german as language:

User picked target 'dw' (gameid 'tinsel')... Looking for a plugin supporting this gameid... Tinsel Engine Starting 'Tinsel engine game' Your game version appears to be unknown. Please, report the following data to the ScummVM team along with name of the game you tried to add and its version/language/etc.: "dw.gra", "c8808ccd988d603dd35dff42013ae7fd", 781656 "english.smp", "4710bd5cc788df1d517370d43abe1101", 343755891

I hope that helps. If not, keep asking and I'll keep answering :-)

Regards, Christoph

comment:7 by fingolfin, 11 years ago

I think this version actually allows switching the language at run time -- but we'll have to do some code modifications to support that.

It seems you have the "4 FLAGS" version, with four languages... if I have some time, I'll try to create a patch which supports this. Could take some time, though..

See also bug #2030682.

by fingolfin, 11 years ago

Attachment: tinsel-4flags.patch added

Patch for detecting the 4FLAGS version

comment:8 by fingolfin, 11 years ago

Could you please try the attached patch -- does the game work correctly for you with it?

Note: This is only a first step. If detection works correctly with this, I would next work on enabling the language selector in the "subtitles" dialog of Discworld. File Added: tinsel-4flags.patch

by fingolfin, 11 years ago

Attachment: tinsel-multiflags.patch added

Enhanced patch which enables language selection

comment:9 by fingolfin, 11 years ago

And here is a second, much enlarged patch, which attempts to enable the code which is responsible for displaying little flags in the subtitles dialog, which allow you to switch the language during run time. Well, at least in theory... I can't test it. File Added: tinsel-multiflags.patch

comment:10 by SF/egore, 11 years ago

Ok, I finally got the time to test the patch. Detection of the game itself works fine. Also the game works great if I set the language to german before starting the game. If I don't set the language I get the classical:

User picked target 'dw' (gameid 'tinsel')... Looking for a plugin supporting this gameid... Tinsel Engine Starting 'Tinsel engine game' Cannot find file english.txt!

I think the configuration dialog of scummvm should only show the languages available ... which would be in my case french, german, italian and spanish.

The good news is: Changing the language in game works!

Is there anything planned to persist that setting?

comment:11 by fingolfin, 11 years ago

I commited a tweaked version of the patch, which hopefully should fix the problem that you have to set a language -- it will fall back to german if an invalid language (like english) is selected (that's what the original code, did, btw). If you could test latest trunk, that would be appreciated.

I also added four detection entries, so that you can select in the detector which language you want -- at least in theory (I can't test ;)

Oh, and DW should now save its settings correctly :).

comment:12 by SF/egore, 11 years ago

I tested the latest trunk and I have only good news: Detection works! I get a dialog to pick which language I'd like to use. I can switch the settings in game and they are changed within scummvms settings. I'm amazed how fast you fixed all these problems and how perfectly it works! Many thanks!

comment:13 by fingolfin, 11 years ago

Glad to hear it works so well ;). Thanks for your collaboration, without it would have been impossible for me to implement this fix.

Now I just need to find somebody with the 5-language and somebody with the 3-language version. And then somebody with the Japanese version (and if I am bored, throw in the hebrew version as an extra bonus? ;).

comment:14 by fingolfin, 11 years ago

Resolution: fixed
Status: newclosed

comment:15 by Strangerke, 6 years ago

Component: --Unset--Engine: Tinsel
Game: Discworld
Owner: fingolfin removed
Note: See TracTickets for help on using tickets.