Opened 4 years ago
Closed 3 years ago
#11445 closed defect (fixed)
SCUMM: DotT - George Washington faces Left instead of Forward, after chopping down the Cherry Tree
| Reported by: | NeoDement | Owned by: | athrxx |
|---|---|---|---|
| Priority: | normal | Component: | Engine: SCUMM |
| Version: | Keywords: | actor, direction, costume | |
| Cc: | NeoDement | Game: | Day of the Tentacle |
Description (last modified by )
As the summary says. As George Washington moves diagonally in this cutscene, he should (according to DOSBox) face forward, but he faces left instead. This actually renders his forward walking animation completely unused.
A screenshot is attached comparing the expected output from DOSBox 0.74-3 to the incorrect output from ScummVM 2.1.0. I have also tested it in the daily build (2.2.0git4446-g0e15ef080), which has the exact same result.
I have also attached a savegame, simply press the second option to run the cutscene. Or run Script 19 at any time in the debug console.
It was the English, CD version of the game, and I'm running Windows 10.
Attachments (2)
Change History (10)
by , 4 years ago
| Attachment: | image-20200426-151357.png added |
|---|
by , 4 years ago
| Attachment: | tentacle-1.s61 added |
|---|
comment:1 by , 4 years ago
| Description: | modified (diff) |
|---|
comment:2 by , 4 years ago
comment:3 by , 4 years ago
Having trouble building versions earlier than v1.2.1 with modern compiler, but that version still exhibits the walking bug so if this is a regression, it is prior to v1.2.1
comment:4 by , 4 years ago
OK... This is room 11 and actors gives Washington as Actor #8. His costume is 63 and stays that way as he moves. mov changes from 0 to 10 and frm from 1 to 2 with dir at 270.
comment:5 by , 4 years ago
I think I will leave the rest for SCUMM engine devs since not an expert on how this is meant to work...
comment:6 by , 4 years ago
There is a similar hack for a bug in Indy 3 (#1237), when in Berlin:
https://github.com/scummvm/scummvm/blob/master/engines/scumm/actor.cpp#L1404
comment:7 by , 4 years ago
| Summary: | George Washington faces Left instead of Forwards after chopping down the Cherry Tree → SCUMM: DotT - George Washington faces Left instead of Forward, after chopping down the Cherry Tree |
|---|
comment:8 by , 3 years ago
| Owner: | set to |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
I have committed a fix to the repo...
The attached savegame will not load on older versions of ScummVM, but by using Boot Params, specifically ./scummvm -b 555 tentacle. You can get Hoagie with the Red Paint before the cutscene and perform the actions to trigger.
Using this, I can confirm that ScummVM has exhibited the final walk of that cutscene as a diagonal left walk of Washington since at least v1.7.0 ... Will try a few earlier versions, but this is not a recent regression.
I wonder if the original interpreter had a hack for this? Will try to pin down the internal state issue to aid SCUMM engine developers in debugging.