Opened 5 years ago

Closed 5 years ago

#10960 closed defect (fixed)

Woodruff: subtitles in vmd videos

Reported by: Dimouse Owned by: bluegr
Priority: normal Component: Engine: Gob
Version: Keywords:
Cc: Game: Woodruff

Description

Inside vmd-videos there are ids for subtitles lines, they are located after byte 05h after table of offsets. This id takes one byte. But in ScummVM it is assumed as 2-byte word. Then if it is for example ff2dh, then the game looks at 65325th line insted of 45th and no subtitle is shown.

To fix this the code in video/coktel_decoder.h should be modified around lines 2073-2076.

} else if (_frames[i].parts[j].type == kPartTypeSubtitle) {

_frames[i].parts[j].id = _stream->readUint16LE();
Speech text file name
_stream->skip(8);

change to:

} else if (_frames[i].parts[j].type == kPartTypeSubtitle) {

_frames[i].parts[j].id = _stream->readByte();
Speech text file name
_stream->skip(9);

Change History (3)

comment:1 by Dimouse, 5 years ago

Component: --Unset-- → Engine: Gob

comment:2 by Filippos Karapetis <bluegr@…>, 5 years ago

In cf17986:

VIDEO: Fix embedded subtitles in VMD videos

This fixes the subtitles in Woodruff - bug 10960

comment:3 by bluegr, 5 years ago

Owner: set to bluegr
Resolution: → fixed
Status: new → closed

This has been fixed in PR #1837:
​https://github.com/scummvm/scummvm/pull/1837

Note: See TracTickets for help on using tickets.