#10960 closed defect (fixed)
GOB: Woodruff: subtitles in vmd videos
Reported by: | Dimouse | Owned by: | bluegr |
---|---|---|---|
Priority: | normal | Component: | Engine: Gob |
Version: | Keywords: | ||
Cc: | Game: | Woodruff |
Description
Inside vmd-videos there are ids for subtitles lines, they are located after byte 05h after table of offsets. This id takes one byte. But in ScummVM it is assumed as 2-byte word. Then if it is for example ff2dh, then the game looks at 65325th line insted of 45th and no subtitle is shown.
To fix this the code in video/coktel_decoder.h should be modified around lines 2073-2076.
} else if (_frames[i].parts[j].type == kPartTypeSubtitle) {
_frames[i].parts[j].id = _stream->readUint16LE();
Speech text file name
_stream->skip(8);
change to:
} else if (_frames[i].parts[j].type == kPartTypeSubtitle) {
_frames[i].parts[j].id = _stream->readByte();
Speech text file name
_stream->skip(9);
Change History (4)
comment:1 by , 6 years ago
Component: | --Unset-- → Engine: Gob |
---|
comment:2 by , 5 years ago
comment:3 by , 5 years ago
Owner: | set to |
---|---|
Resolution: | → fixed |
Status: | new → closed |
This has been fixed in PR #1837:
https://github.com/scummvm/scummvm/pull/1837
comment:4 by , 4 months ago
Summary: | Woodruff: subtitles in vmd videos → GOB: Woodruff: subtitles in vmd videos |
---|
In cf17986: