Opened 7 years ago

Closed 7 years ago

#9990 closed defect (fixed)

TITANIC: Suspicious fall-through cases

Reported by: bgK Owned by: dreammaster
Priority: normal Component: Engine: Titanic
Version: Keywords:
Cc: Game: Starship Titanic

Description

GCC 7 enables by default the -Wimplicit-fallthrough=3 option which reports as warnings switch / case fall-throughs that are not annotated.

The Titanic engine generates a few of these for cases that look unintentional and possibly need to be checked against the disassembly.

See the attached file for the warnings generated by GCC.

Attachments (1)

titanic_fallthrough_warnings.txt​ (3.3 KB ) - added by bgK 7 years ago.
GCC warnings

Download all attachments as: .zip

Change History (2)

by bgK, 7 years ago

Attachment: titanic_fallthrough_warnings.txt​ added

GCC warnings

comment:1 by dreammaster, 7 years ago

Owner: set to dreammaster
Resolution: → fixed
Status: new → closed

Thanks for that. I double checked each of them, and they were all meant to have breaks.

Note: See TracTickets for help on using tickets.