Opened 8 years ago

Closed 8 years ago

Last modified 11 months ago

#9293 closed patch

AMIGAOS4: Configure update

Reported by: raziel- Owned by:
Priority: normal Component: Port: AmigaOS4
Keywords: Cc:
Game:

Description

Sorry for yet another configure change, i haven't got the time to test it until now

We drop -mcpu=750 -mtune=7400 as this was done on the very first port to the PPC base AmigaOS4.
Since then the platform has been widened when it comes to hardware and lots more cpu types are supported, thus we lose that specific parameters.
Tested on a non-750, non-7400 cpu and working

Also dropping the strict align of memory as since this was used a new memory sub system has been introduced which makes use of an explicit alignment obsolete (or so i think).
Tested on different platforms and working with no drawbacks so far

Index: configure

--- configure (revision cc074b0)
+++ configure (working copy)
@@ -1492,7 +1492,7 @@
case $_host_os in
amigaos*)
- CXXFLAGS="$CXXFLAGS -mcrt=newlib -mstrict-align -mcpu=750 -mtune=7400"
+ CXXFLAGS="$CXXFLAGS -mcrt=newlib"
LDFLAGS="$LDFLAGS -mcrt=newlib -use-dynld -L/sdk/local/newlib/lib"
# We have to use 'long' for our 4 byte typedef because AmigaOS already typedefs (u)int32
# as (unsigned) long, and consequently we'd get a compiler error otherwise.
type_4_byte='long'

Sorry for yet another SVN diff/Git mixup...still no git here :-)

Thanks a lot

Ticket imported from: #3246518. Ticket imported from: patches/1398.

Attachments (1)

AmigaOS4.diff (1.3 KB ) - added by raziel- 8 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 by raziel-, 8 years ago

I revised all the AmigaOS4 workarounds in those places i could easily change *and* test and here is the result (diff attached)

some notes:

configure - grep
i tested this with my latest sdk and it seems grep has been updated to finally support the "-" input file, so we may as well drop the workaround ... feel free to adapt the line to the latest techniques

configure - host_os
cleanup

configure - memalign
Not sure if that comment is needed...feel free to drop it

Makefile.common
grep can now handle (see above) what was meant to be an update to the code back then.
The workaround for AmigaOS4 can be dropped
Feel free to update the line to the latest technique...it was taken from the revision before it was changed to the workaround, so it may as well be out of date

Thank you

by raziel-, 8 years ago

Attachment: AmigaOS4.diff added

comment:2 by Strangerke, 8 years ago

Status: newclosed

comment:3 by Strangerke, 8 years ago

Tested and committed (git 54ddd000dcbe43f4b58d30b6b7e98775233bff01)

comment:4 by digitall, 11 months ago

Component: Port: AmigaOS4
Note: See TracTickets for help on using tickets.