Opened 9 years ago

Closed 9 years ago

Last modified 13 months ago

#9287 closed patch

WINCE: Make scummvm compile and run again for WinCE platform

Reported by: CeRiAl Owned by: fingolfin
Priority: normal Component: Port: WinCE
Keywords: Cc:
Game:

Description

This patch makes the WinCE port of scummvm compile and run again.

Ticket imported from: #3202337. Ticket imported from: patches/1392.

Attachments (1)

scummvm-df1a800-wince.patch (160.2 KB ) - added by CeRiAl 9 years ago.
WINCE: Make scummvm compile and run again for WinCE platform

Download all attachments as: .zip

Change History (9)

by CeRiAl, 9 years ago

Attachment: scummvm-df1a800-wince.patch added

WINCE: Make scummvm compile and run again for WinCE platform

comment:1 by fingolfin, 9 years ago

Thanks! After a brief review, I committed this patch as-is, figuring that things can't possible become worse than they are ;):

comment:2 by fingolfin, 9 years ago

Owner: set to fingolfin
Status: newclosed

comment:3 by fingolfin, 9 years ago

I have not yet gotten around to actually trying this, but here's a quick question based on a look at the code: Why is SparkleMenu a class? It only contains one method, no members... Shouldn't it just be a namespace, if at all?

Did you test the auto-updating yet (of course, if you did, then using a custom website, and not using scummvm.org) ?

If we add this, we need to do some extra stuff:
* Generate a DSA keypair, and decide where to keep the private one (probably Eugene or me would have a copy initially. BTW, this is yet another reason why we should establish a GPG network)
* Add "dists/macosx/scummvm_appcast.xml" to the list of files that need to be updated prior to release
* Add a reminder to the release HOWTO that the only version of scummvm_appcast.xml needs to be updated.
* ... more ... ?

comment:4 by fingolfin, 9 years ago

Argh... Sorry, wrong tracker item!

comment:5 by fingolfin, 9 years ago

Actually, we still get a compiler error, but now in one of the engines, see <http://buildbot.scummvm.org/builders/master-wince/builds/233/steps/compile/logs/stdio>. Looks as if one of our symbols clashes with something defined by WinCE. Can you take a look, and if possible, submit a fix (on a new patch tracker item) ?
Thanks! :)

comment:6 by CeRiAl, 9 years ago

I saw in the commit history that the bug related to the mohawk engine was already fixed. However, yesterday I tried to compile the latest trunk @home and the Sword 2.5 now failed. The buildbot has no problem with this because he skips the Sword 2.5 because configure couldn't find libpng. But as I have this library in my setup it tried to compile Sword 2.5 and failed. I hope I find enough time this night to submit a patch for this. Should I also supply a prebuilt libpng for the buildbot?

comment:7 by CeRiAl, 9 years ago

After having actually looked for the error, the problem is obvious (yesterday, I've just seen that an error occured and went to bed without even looking at the message):
The error occurs in /engines/sword25/util/lua/lauxlib.cpp, because it tries to use errno & strerror which is not available in WinCE. My question now is: should this problem be fixed in the engine, or should I supply (dummy?) replacements for these functions in missing.cpp?

comment:8 by digitall, 13 months ago

Component: Port: WinCE
Note: See TracTickets for help on using tickets.