Opened 10 years ago

Closed 10 years ago

Last modified 21 months ago

#9174 closed patch

BRA: zone running fixes

Reported by: fuzzie Owned by: peres
Priority: normal Component: Engine: Parallaction
Keywords: Cc:
Game:

Description

Fixes using the remote on the television (hear zone without sound) and talking to the Japanese tourist (speak zone without dialogue). Patch against trunk.

Ticket imported from: #3003382. Ticket imported from: patches/1279.

Attachments (2)

0001-handle-speak-zones-without-dialogue.patch (798 bytes ) - added by fuzzie 10 years ago.
0002-parse-play-music-from-BRA-hear-zones.patch (2.7 KB ) - added by fuzzie 10 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 by fuzzie, 10 years ago

Owner: set to peres

comment:2 by peres, 10 years ago

The first part of your patch (HEAR zones) is a workaround needed because parsing of BRA-specific HEAR zones parameters is not yet implemented (in this case, the MUSIC parameter is ignored). The patch fixes a crash in the game, so your code could be merged provided that there is a clear comment about it being a workaround.

The second part (SPEAK zones) is fine. In the case you spotted the dialogue is triggered by the script used to move the tourist's head towards Doug before they talk, so the SPEAK zone definition is empty.

I will split the patch and apply it tomorrow, unless you want to implement the missing parser :)

comment:3 by fuzzie, 10 years ago

Oke, split into two patches: one for the SPEAK bit, and a new HEAR one with music parsing/playing (which seems to work).

comment:4 by peres, 10 years ago

I committed both patches to trunk (#0002 with little readability changes) in r49103 and r49105.

I am closing this ticket.

comment:5 by peres, 10 years ago

Status: newclosed

comment:6 by digitall, 21 months ago

Component: Engine: Parallaction
Note: See TracTickets for help on using tickets.