#9174 closed patch
BRA: zone running fixes
| Reported by: | fuzzie | Owned by: | peres |
|---|---|---|---|
| Priority: | normal | Component: | Engine: Parallaction |
| Version: | Keywords: | ||
| Cc: | Game: |
Description
Fixes using the remote on the television (hear zone without sound) and talking to the Japanese tourist (speak zone without dialogue). Patch against trunk.
Ticket imported from: #3003382. Ticket imported from: patches/1279.
Attachments (2)
Change History (8)
comment:1 by , 14 years ago
| Owner: | set to |
|---|
comment:2 by , 14 years ago
by , 14 years ago
| Attachment: | 0001-handle-speak-zones-without-dialogue.patch added |
|---|
by , 14 years ago
| Attachment: | 0002-parse-play-music-from-BRA-hear-zones.patch added |
|---|
comment:3 by , 14 years ago
Oke, split into two patches: one for the SPEAK bit, and a new HEAR one with music parsing/playing (which seems to work).
comment:4 by , 14 years ago
I committed both patches to trunk (#0002 with little readability changes) in r49103 and r49105.
I am closing this ticket.
comment:5 by , 14 years ago
| Status: | new → closed |
|---|
comment:6 by , 6 years ago
| Component: | → Engine: Parallaction |
|---|
Note:
See TracTickets
for help on using tickets.
The first part of your patch (HEAR zones) is a workaround needed because parsing of BRA-specific HEAR zones parameters is not yet implemented (in this case, the MUSIC parameter is ignored). The patch fixes a crash in the game, so your code could be merged provided that there is a clear comment about it being a workaround.
The second part (SPEAK zones) is fine. In the case you spotted the dialogue is triggered by the script used to move the tourist's head towards Doug before they talk, so the SPEAK zone definition is empty.
I will split the patch and apply it tomorrow, unless you want to implement the missing parser :)