Opened 10 years ago

Closed 10 years ago

Last modified 23 months ago

#9175 closed patch (fixed)

BRA: handle SELFUSE flag

Reported by: fuzzie Owned by: peres
Priority: normal Component: Engine: Parallaction
Keywords: Cc:
Game:

Description

This adds checks for kFlagsSelfuse in two new places: checkZoneBox (as an alternative to the NS-style check for X == -1) and in the input code (as well as kFlagsNoWalk).

Again, accompanied by "I have no idea how this is meant to work" disclaimer (would you prefer that the parser change the X location and set the noWalk flag?), but this seems to be the right flag, at least.

Ticket imported from: #3003626. Ticket imported from: patches/1280.

Attachments (2)

0001-check-kFlagsSelfuse-in-checkZoneBox-and-check-it-alo.patch (1.4 KB ) - added by fuzzie 10 years ago.
check-kFlagsYourself.patch (2.7 KB ) - added by peres 10 years ago.

Download all attachments as: .zip

Change History (11)

comment:1 by fuzzie, 10 years ago

Owner: set to peres

comment:2 by fuzzie, 10 years ago

For clarity: this is a BRA-only flag, so this shouldn't affect NS. The result is that you can 'use' objects on your own character; for instance, you can open the envelope you start the game with.

comment:3 by peres, 10 years ago

Status: newpending

comment:4 by peres, 10 years ago

Thanks for spotting those two places that need to be patched, but you should be testing kFlagsYourself instead. SELFUSE (misleadingly enough) marks zones that must be preserved across location changes (see Parallaction::freeZones and so on). The flags often occur together on zones, so I suppose you were lucky with your testing :)

Please see the attached patch.

comment:5 by fuzzie, 10 years ago

This was also a stupid mistake on my part: I tested this by removing the YOURSELF flag from some zones in the DOS version, but I didn't realise that COMMON.SLF has a copy of everything!

I checked again by modifying COMMON.SLF and you're right. Your patch seems to work fine, thankyou.

comment:6 by fuzzie, 10 years ago

Status: pendingnew

by peres, 10 years ago

Attachment: check-kFlagsYourself.patch added

comment:7 by peres, 10 years ago

Resolution: fixed
Status: newclosed

comment:8 by peres, 10 years ago

I updated my patch and applied it in 3 rounds (r49136-r49138).

comment:9 by digitall, 23 months ago

Component: Engine: Parallaction
Note: See TracTickets for help on using tickets.