#9150 closed patch
SCUMM: Unneeded pointer dereference
| Reported by: | salty-horse | Owned by: | fingolfin |
|---|---|---|---|
| Priority: | normal | Component: | Engine: SCUMM |
| Version: | Keywords: | ||
| Cc: | Game: |
Description
engines/scumm/gfx.cpp has this statement:
*smap_ptr++;
Since the increment (++) takes precedence over the pointer dereference (*), the dereference is pointless (pun not intended). It's probably a copy-paste from the lines around it, which do make use of the dereference.
The attached patch removes the * from the offending lines. I didn't test it.
Ticket imported from: #2973283. Ticket imported from: patches/1255.
Attachments (1)
Change History (4)
by , 14 years ago
| Attachment: | deref.patch added |
|---|
comment:1 by , 14 years ago
comment:2 by , 14 years ago
| Owner: | set to |
|---|---|
| Status: | new → closed |
comment:3 by , 5 years ago
| Component: | → Engine: SCUMM |
|---|
Note:
See TracTickets
for help on using tickets.
Committed, thanks.