Opened 10 years ago

Closed 10 years ago

Last modified 12 months ago

#9150 closed patch

SCUMM: Unneeded pointer dereference

Reported by: salty-horse Owned by: fingolfin
Priority: normal Component: Engine: SCUMM
Keywords: Cc:
Game:

Description

engines/scumm/gfx.cpp has this statement:

*smap_ptr++;

Since the increment (++) takes precedence over the pointer dereference (*), the dereference is pointless (pun not intended).
It's probably a copy-paste from the lines around it, which do make use of the dereference.

The attached patch removes the * from the offending lines.
I didn't test it.

Ticket imported from: #2973283. Ticket imported from: patches/1255.

Attachments (1)

deref.patch (653 bytes ) - added by salty-horse 10 years ago.

Download all attachments as: .zip

Change History (4)

by salty-horse, 10 years ago

Attachment: deref.patch added

comment:1 by fingolfin, 10 years ago

Committed, thanks.

comment:2 by fingolfin, 10 years ago

Owner: set to fingolfin
Status: newclosed

comment:3 by digitall, 12 months ago

Component: Engine: SCUMM
Note: See TracTickets for help on using tickets.