Opened 10 years ago

Closed 9 years ago

Last modified 12 months ago

#9149 closed patch

SCUMM: autodetection for diskimage contents

Reported by: SF/tobigun Owned by: sev-
Priority: normal Component: Engine: SCUMM
Keywords: Cc:
Game:

Description

At the moment, ScummVM checks MD5 hashes only for the C64 .d64 or Apple .dsk disk-image containers but not for its contents. This is inconvenient as ScummVM is also able to handle the unpacked LFL game data. So those LFLs are not detected at the moment. In addition ScummVM might not recognize the game correctly if the disk directory was changed or if a savegame was saved on the disk (I remember that some people used floppy hole punchers to make the floppies writeable but I don't know if saving a savegame destroyed the game date).

The patch just calculates MD5 hashes for the 00.LFL files even if just a disk-image is present, so there is no need to add two MD5 hashes for each version. There were five MD5 hashes for the C64 versions before (two English, two German and one Italian). I already added the hashes for my two German versions.

It would be cleaner if the SearchMan.addDirectory() and SearchMan.remove() calls could be removed somehow, but File::open() which is called by ScummDiskImage requires the path of the two disk images to be registered in the SearchManager.

Maybe you like this patch. If not, maybe someone can use this as a base for a better approach.

Ticket imported from: #2971742. Ticket imported from: patches/1254.

Attachments (1)

autodetect_diskimg.patch (8.9 KB ) - added by SF/tobigun 10 years ago.

Download all attachments as: .zip

Change History (6)

by SF/tobigun, 10 years ago

Attachment: autodetect_diskimg.patch added

comment:1 by fingolfin, 10 years ago

I really like the idea of this patch, as described. Sounds cool and like the "right thing" to do. That said, I haven't yet had a chance to look at the implementation, sorry :-).

comment:2 by fingolfin, 10 years ago

Summary: Scumm: autodetection for diskimage contentsSCUMM: autodetection for diskimage contents

comment:3 by sev-, 9 years ago

Owner: set to sev-
Status: newclosed

comment:4 by sev-, 9 years ago

Excellent! I added NES bundle handling and committed the patch, properly updating md5scumm.txt file

comment:5 by digitall, 12 months ago

Component: Engine: SCUMM
Note: See TracTickets for help on using tickets.