Opened 10 years ago

Closed 10 years ago

Last modified 12 months ago

#9027 closed patch (outdated)

GSOC09 extraction tool patch

Reported by: SF/remere Owned by: SF/remere
Priority: normal Component: Tools
Keywords: Cc:
Game:

Description

Little late due to misunderstanding on my part.

Just a patch of changing command line arguments for one tool (I've already converted almost all of them, keeping it brief for clarity), also contains the util file, which all the tools use for their CLI parsing (and path handling). Most time was spent thinking and fighting my fingers from breaking the coding conventions. ;)

It is questionable if the util.h/.cpp should contain C++ code, I originally wrote it to use only C. But then I realized all tools use C++ anyways (infact, forcing C compiler almost causes all tools to fail), and chose to create a Filename class for clarity. Kept the STL or any advanced features out of it, so even the weakest C++ compiler should be able to compile it without problems (I think).

Oh, and I already have SVN access, submitting it here to hear your opinions.

Ticket imported from: #2802670. Ticket imported from: patches/1132.

Attachments (1)

svmp.patch (7.0 KB ) - added by SF/remere 10 years ago.
The .patch file

Download all attachments as: .zip

Change History (4)

by SF/remere, 10 years ago

Attachment: svmp.patch added

The .patch file

comment:1 by fingolfin, 10 years ago

The tools are written in C++ (even if in many cases it's just C and a bit more ;), so util.h and util.cpp should be in C++. Don't worry about that.

Overall the patch looks OK to me. Quick side note (totally unrelated to the actual patch: It would be nice to unify the tools more, too; e.g. get rid of those custom ULONG etc. types if possible, replacing them by uint32 etc. So if you are bored, feel free to do that ;)

comment:2 by fingolfin, 10 years ago

Resolution: outdated
Status: newclosed

comment:3 by digitall, 12 months ago

Component: Tools
Note: See TracTickets for help on using tickets.