Opened 12 years ago

Closed 11 years ago

Last modified 2 years ago

#8997 closed patch (wontfix)

GSOC09: Objectifying CruisE - Trivial Patch #1

Reported by: SF/remoun Owned by: dreammaster
Priority: normal Component: Engine: Cruise
Keywords: Cc:
Game:

Description

A trivial, rather hacky refactoring of the Cell struct in the CruisE: * moved the functions in cell.h into cellStruct, replacing the (cellStruct *) parameter with 'this'. * updated calling functions accordingly

Ticket imported from: #2742211. Ticket imported from: patches/1102.

Attachments (1)

Cruise_Cell.patch (20.0 KB ) - added by SF/remoun 12 years ago.
Changes to Cruise::cellStruct (now Cruise::Cell), as of SVN trunk rev. 39900

Download all attachments as: .zip

Change History (11)

by SF/remoun, 12 years ago

Attachment: Cruise_Cell.patch added

Changes to Cruise::cellStruct (now Cruise::Cell), as of SVN trunk rev. 39900

comment:1 by SF/remoun, 12 years ago

Made another couple of changes: * renamed cellStruct to Cell * renamed (the global variable) cellHead to g_cellHead * moved freeObjectList from function.h/cpp to Cell * added an addCellAfter function, for linked list-convenience * fixed capitalization of 'currentcellHead' in saveload.cpp

comment:2 by fingolfin, 12 years ago

Summary: Objectifying CruisE - Trivial Patch #1 (GSoC Patch)GSOC09: Objectifying CruisE - Trivial Patch #1

comment:3 by fingolfin, 12 years ago

Thank you for your submission, we will soon review it in detail.

comment:4 by djwillis, 12 years ago

Patch reviewed.

comment:5 by djwillis, 12 years ago

Owner: set to djwillis

comment:6 by fingolfin, 11 years ago

"Patch reviewed" -- OK, but should this patch no be accepted, rejected or revised? :)

Maybe dreammaster (who recently worked on Cruise a bit) can judge it better than us?

comment:7 by fingolfin, 11 years ago

Owner: changed from djwillis to dreammaster

comment:8 by dreammaster, 11 years ago

It may be a trivial refactoring, but it also causes the engine to hang when integrated. I recall from prior discussions in the group that remoun didn't have a copy of Cruise handy to test the changes on, so it's likely there some fundamental flaw in the changes that were made.

Given that, I'm rejecting the patch for integration. I'd recommend that anyone wanting to objectify the engine do the Cell class again from scratch, and perhaps use standard ScummVM list classes for holding the cells, rather than trying to maintain a doubly-linked list (as this does).

comment:9 by dreammaster, 11 years ago

Resolution: wontfix
Status: newclosed

comment:10 by digitall, 2 years ago

Component: Engine: Cruise
Note: See TracTickets for help on using tickets.