Opened 12 years ago

Closed 12 years ago

Last modified 2 years ago

#8996 closed patch

GSOC09: Compression GUI Tool touchup

Reported by: SF/remere Owned by: fingolfin
Priority: normal Component: Tools
Keywords: Cc:
Game:

Description

Patch submission for GSOC, (remere@gmail.com)

*Added some comments in the header, should be helpful to anyone trying to edit the tool. *Removed redundant use of this-> (Why?, was not in the code guidelines either) *Fixed spelling *Fixed possible ID collision (although far-fetched) *No need to specify size of option arrays any longer (this certainly was error-prone) *Maybe more?

Ticket imported from: #2741849. Ticket imported from: patches/1101.

Attachments (1)

scummvmtool.patch (51.9 KB ) - added by SF/remere 12 years ago.
SVN diff file

Download all attachments as: .zip

Change History (7)

by SF/remere, 12 years ago

Attachment: scummvmtool.patch added

SVN diff file

comment:1 by SF/remere, 12 years ago

Summary: Compression GUI Tool touchupCompression GUI Tool touchup (GSOC patch)

comment:2 by fingolfin, 12 years ago

Thank you for your submission, we will soon review it in detail.

comment:3 by fingolfin, 12 years ago

Summary: Compression GUI Tool touchup (GSOC patch)GSOC09: Compression GUI Tool touchup

comment:4 by fingolfin, 12 years ago

FYI, the redundant use of "this-> " was removed on 2009-03-28 by me (after you told me about it back then ;). You may want to run "svn up" etc. before submitting patches, to make sure you are really looking at the latest version of the code.

I commited the rest now.

comment:5 by fingolfin, 12 years ago

Owner: set to fingolfin
Status: newclosed

comment:6 by digitall, 2 years ago

Component: Tools
Note: See TracTickets for help on using tickets.