Opened 12 years ago

Closed 12 years ago

Last modified 2 years ago

#8969 closed patch

PS2: hashmap workaround

Reported by: sunmax Owned by: sunmax
Priority: normal Component: Port: PS2
Keywords: Cc:
Game:

Description

Special #ifdef for PS2 vintage gcc to allow hashmap in branch 0.13.x and trunk to compile.

Ticket imported from: #2659821. Ticket imported from: patches/1074.

Attachments (2)

ps2-hashmap.patch (671 bytes ) - added by sunmax 12 years ago.
ps2-hashmap.patch
ps2-hashmap-new.patch (630 bytes ) - added by sunmax 12 years ago.

Download all attachments as: .zip

Change History (13)

by sunmax, 12 years ago

Attachment: ps2-hashmap.patch added

ps2-hashmap.patch

comment:1 by fingolfin, 12 years ago

Summary: PS2 : hashmap workaroundPS2: hashmap workaround

comment:2 by fingolfin, 12 years ago

This patch is of course not very nice, since it has to add #ifdef tricks to hashmap.h. Well, we didn't see a better solution, so what...

But at the very very least, when adding such a hack, there should be a comment next to it explaining it. Something like: // Workaround a bug in GCC X.Y.Z in the PS2SDK, which generates an ICE/compile error/earth quake when we call the constructor of _defaultVal explicitly.

comment:3 by fingolfin, 12 years ago

I.e. I am asking you to submit a revised patch which adds such an explanatory comment. Other than that, well, I am not happy with this solution, but we have similar hacks around other compiler bugs, so...

by sunmax, 12 years ago

Attachment: ps2-hashmap-new.patch added

comment:4 by sunmax, 12 years ago

Aye Max,

revised patch in tracker.

Let me know if you like this better so I will commit to trunk and 0.13.0

ciao, -max File Added: ps2-hashmap-new.patch

comment:5 by fingolfin, 12 years ago

Better, yeah.

comment:6 by fingolfin, 12 years ago

Feel free to commit it.

comment:7 by fingolfin, 12 years ago

Owner: set to sunmax

comment:8 by sunmax, 12 years ago

Committed to both trunk and 0.13.0 as per Max' approval. Closed.

comment:9 by sunmax, 12 years ago

Status: newclosed

comment:10 by sunmax, 12 years ago

Committed to both trunk and 0.13.0 as per Max' approval. Closed.

comment:11 by digitall, 2 years ago

Component: Port: PS2
Note: See TracTickets for help on using tickets.