Context Navigation

← Previous Ticket
Next Ticket →

#8969 closed patch

PS2: hashmap workaround

Reported by:	sunmax	Owned by:	sunmax
Priority:	normal	Component:	Port: PS2
Version:		Keywords:
Cc:		Game:

Description

Special #ifdef for PS2 vintage gcc to allow hashmap in branch 0.13.x and trunk to compile.

Ticket imported from: #2659821. Ticket imported from: patches/1074.

Attachments (2)

ps2-hashmap.patch (671 bytes ) - added by sunmax 15 years ago.: ps2-hashmap.patch
ps2-hashmap-new.patch (630 bytes ) - added by sunmax 15 years ago.

Download all attachments as: .zip

Change History (13)

by sunmax, 15 years ago

Attachment:	ps2-hashmap.patch added

ps2-hashmap.patch

comment:1 by fingolfin, 15 years ago

Summary:	PS2 : hashmap workaround → PS2: hashmap workaround

comment:2 by fingolfin, 15 years ago

This patch is of course not very nice, since it has to add #ifdef tricks to hashmap.h. Well, we didn't see a better solution, so what...

But at the very very least, when adding such a hack, there should be a comment next to it explaining it. Something like: // Workaround a bug in GCC X.Y.Z in the PS2SDK, which generates an ICE/compile error/earth quake when we call the constructor of _defaultVal explicitly.

comment:3 by fingolfin, 15 years ago

I.e. I am asking you to submit a revised patch which adds such an explanatory comment. Other than that, well, I am not happy with this solution, but we have similar hacks around other compiler bugs, so...