#8955 closed patch
Patches for BS1 bug ID #1977094
| Reported by: | criezy | Owned by: | eriktorbjorn |
|---|---|---|---|
| Priority: | normal | Component: | Engine: Sword1 |
| Version: | Keywords: | ||
| Cc: | Game: | Broken Sword 1 |
Description
It seems I cannot post files directly in the bug report, therefore I am posting them here instead.
The two patches both solve bug #1977094 (error displayed instead of subtitle in Syria). The original issue is that the sentence is missing from the text cluster file for some languages (German, French and Spanish). This is correctly caught in ScummVM BS1 engine, but it replaces the missing subtitle by an error string.
The first patch replaces missing subtitles by an empty string, therefore no subtitles are displayed (there is still a warning in the console).
The second patch contains the first one and in addition hardcode the subtitles for that particular sentence. Actually I have only done it for the French language as I don't know what the subtitle should be for the German or Spanish languages. Therefore this patch needs to be completed by somebody who knows what the subtitle should be in these languages (there is a static string array to complete at the end of objectman.cpp file).
Ticket imported from: #2602772. Ticket imported from: patches/1060.
Attachments (2)
Change History (19)
by , 15 years ago
| Attachment: | bs1_no_subtitle.patch added |
|---|
comment:1 by , 15 years ago
| Summary: | Patches for bug ID #1977094 → Patches for BS1 bug ID #1977094 |
|---|
comment:2 by , 15 years ago
Hi Torbjörn, can you take a look at this and maybe commit it, if it seems to be OK?
comment:3 by , 15 years ago
| Owner: | set to |
|---|
comment:4 by , 15 years ago
People keep mistaking me for someone who knows how the Broken Sword 1 engine works...
I guess providing a hard-coded subtitle string for the missing one is best from the player's point of view, and it looks like it should work.
comment:5 by , 15 years ago
The patch with the hard-coded string seems to work well, but we'd need a text for the German and Spanish translations, too. (And Portuguese? The game crashes for me if I try to use that language with my English version.)
comment:6 by , 15 years ago
The portuguese version does crash for me as well. This is because the portuguese text is not present in my version (I only have the first six languages in text.clu) and apparently in yours. I don't know if it was added for a later release (e.g. in Brazil) or if this is a fan translation.
comment:7 by , 15 years ago
I can't submit an updated patch file so this is the spanish message
"¿Eh?", // Spanish
I'm not sure if it is show correctly the first character '¿', or it is needed in UTF-8, or ASCII code...
comment:8 by , 15 years ago
Based on other texts, the upside down question mark appears to be character code 191, so maybe they're using ISO 8859-1 (Latin-1) as their character encoding. In other words, this ought to work:
"\277Eh?", // Spanish
comment:10 by , 15 years ago
| Owner: | changed from to |
|---|
comment:12 by , 15 years ago
Or lordhoto should be able to, as he reported the bug in the first place for the German version.
comment:13 by , 15 years ago
| Owner: | changed from to |
|---|
comment:14 by , 15 years ago
German: "Oh?" (based on the audio I got while playing that scene using the savegame from the bug report).
So we now have spanish and german, does that mean somebody will commit it? Torbjörn? :)
comment:15 by , 15 years ago
I guess so. Screw the Portuguese. At least until we know if that version needs a hard-coded translation. :-)
comment:16 by , 15 years ago
| Status: | new → closed |
|---|
comment:17 by , 5 years ago
| Component: | → Engine: Sword1 |
|---|---|
| Game: | → Broken Sword 1 |
No subtitle patch