Opened 11 years ago

Closed 11 years ago

Last modified 21 months ago

#8954 closed patch (wontfix)

ALL: Drop dists/msvc71 (and dists/msvc7)

Reported by: SF/quietust Owned by: fingolfin
Priority: normal Component: Port: Win32
Keywords: Cc:
Game:

Description

Ever since revision 36087, both graphics\scaler\hq2x.cpp and graphics\scaler\hq3x.cpp completely fail to compile under MSVC71, each reporting one hundred syntax errors (mostly "missing ',' before ';'") followed by a fatal error "error count exceeds 100". Given that these changes are handled correctly by all newer compilers (including MSVC9 and likely MSVC8 as well), it's probably safe to drop support altogether for this outdated compiler. In all likelihood, MSVC70 is also unable to compile these files, so it can be dropped as well.

Additionally, all versions of MSVC have been unable to compile since revision 36007, as all of their project files continue to refer to the now nonexistent backends\saves\compressed\compressed-saves.cpp.

Ticket imported from: #2600794. Ticket imported from: patches/1059.

Attachments (4)

hq2x.txt (8.8 KB ) - added by SF/quietust 11 years ago.
Errors compiling graphics\scaler\hq2x.cpp
hq3x.txt (8.8 KB ) - added by SF/quietust 11 years ago.
Errors compiling graphics\scaler\hq3x.cpp
hq2x.i.bz2 (10.1 KB ) - added by SF/quietust 11 years ago.
cl /P hq2x.cpp -I..\.. -DWIN32
hq3x.i.bz2 (10.5 KB ) - added by SF/quietust 11 years ago.
cl /P hq3x.cpp -I..\.. -DWIN32

Download all attachments as: .zip

Change History (12)

comment:1 by SF/quietust, 11 years ago

Summary: ALL: Drop dist/msvc71 (and dist/msvc7)ALL: Drop dists/msvc71 (and dists/msvc7)

comment:2 by bluegr, 11 years ago

Sorry about this, I updated the MSVC files for revision #36007

As for the warnings... can you tell us what warnings are you getting? Please attach them to this report

We do support older compilers, e.g. older versions of GCC, so if it's possible to make this code more understandable for older versions of MSVC, we could do so, instead of dropping support for it altogether

by SF/quietust, 11 years ago

Attachment: hq2x.txt added

Errors compiling graphics\scaler\hq2x.cpp

by SF/quietust, 11 years ago

Attachment: hq3x.txt added

Errors compiling graphics\scaler\hq3x.cpp

comment:3 by SF/quietust, 11 years ago

Errors (not warnings) for hq2x.cpp and hq3x.cpp are attached, and it's pretty much one error on *every single line* (or at least until it gives up entirely and aborts partway through).

comment:4 by fingolfin, 11 years ago

That's a weird error. I'd like to test whether one can fix it before dropping MSVC 7, though.

Can MSVC produce a preprocessed version of the code in graphics/scaler/hq2x.cpp ? I wonder what it thinks that line contains to make it produce this weird error.

by SF/quietust, 11 years ago

Attachment: hq2x.i.bz2 added

cl /P hq2x.cpp -I..\.. -DWIN32

by SF/quietust, 11 years ago

Attachment: hq3x.i.bz2 added

cl /P hq3x.cpp -I..\.. -DWIN32

comment:5 by SF/quietust, 11 years ago

Preprocessed versions of both files have been uploaded.

For reference, the line "*(q) = interpolate16_2_1_1<Graphics::ColorMasks<565>>(w5, w4, w2);" gives the error "syntax error : missing ',' before ';'".

comment:6 by fingolfin, 11 years ago

Seems MSVC71 is working again, so i am rejecting this for now.

comment:7 by fingolfin, 11 years ago

Owner: set to fingolfin
Resolution: wontfix
Status: newclosed

comment:8 by digitall, 21 months ago

Component: Port: Win32
Note: See TracTickets for help on using tickets.