Opened 12 years ago

Closed 12 years ago

Last modified 19 months ago

#8896 closed patch

Do not mark stack as executable in HQx scaler

Reported by: SF/keescook Owned by: fingolfin
Priority: normal Component: Graphics: Scalers
Keywords: Cc:
Game:

Description

The attached patch gets rid of unneeded executable stack markings in the final ELF:

GNU_STACK 0x000000 0x00000000 0x00000000 0x00000 0x00000 RW 0x4

vs the current:

GNU_STACK 0x000000 0x00000000 0x00000000 0x00000 0x00000 RWE 0x4

I noticed this while doing executable stack reviews in Ubuntu, but saw that Fedora has been carrying this patch for a while now.

http://cvs.fedoraproject.org/viewcvs/devel/scummvm/scummvm-0.9.1-no-execstack.patch?view=markup

Ticket imported from: #2014663. Ticket imported from: patches/1001.

Attachments (1)

scummvm-0.9.1-no-execstack.patch (786 bytes ) - added by SF/keescook 12 years ago.
mark up asm to stop executable stack

Download all attachments as: .zip

Change History (6)

by SF/keescook, 12 years ago

mark up asm to stop executable stack

comment:1 by bluegr, 12 years ago

Moving to patches

comment:2 by bluegr, 12 years ago

Component: --Unset--

comment:3 by fingolfin, 12 years ago

Commited, thanks. Will be in 0.12.0.

comment:4 by fingolfin, 12 years ago

Owner: set to fingolfin
Status: newclosed
Summary: builds with unneeded executable stackDo not mark stack as executable in HQx scaler

comment:5 by digitall, 19 months ago

Component: Graphics: Scalers
Note: See TracTickets for help on using tickets.