Opened 12 years ago

Closed 11 years ago

Last modified 15 months ago

#8897 closed patch

Patch for reducing the BSS size of Cine engine

Reported by: SF/buddha_ Owned by: SF/buddha_
Priority: normal Component: Engine: Cine
Keywords: Cc:
Game:

Description

Here's a patch to reduce the BSS size of the Cine engine (There's been talk about reducing the BSS size of the engines on the mailing list recently). Didn't know if I should just commit this straight to the trunk as the trunk's in code freeze at the moment so took the more cautious approach of making it a patch.

I just encapsulated the 64kB global array textTable into a struct and made an instance of that struct to be a member variable of the CineEngine class. That should make it to be allocated from the heap. I know the solution isn't maybe the cleanest of approaches, but I think it is 1) easy, 2) not error prone, 3) small. So IMO any possibility of regressions is extremely small.

NOTE: The patch uses bytes 0x0d, 0x0a as the newline convention.

Ticket imported from: #2019455. Ticket imported from: patches/1002.

Attachments (1)

r33084-cine-bss_size_reduction.patch (2.9 KB ) - added by SF/buddha_ 12 years ago.
Patch to reduce the BSS size of Cine engine (0x0d + 0x0a as newlines!)

Download all attachments as: .zip

Change History (8)

by SF/buddha_, 12 years ago

Patch to reduce the BSS size of Cine engine (0x0d + 0x0a as newlines!)

comment:1 by sev-, 12 years ago

Owner: changed from sev- to SF/buddha_

comment:2 by sev-, 12 years ago

Heh, clever! Please, commit it.

comment:3 by fingolfin, 11 years ago

What is the status of this item?

comment:4 by fingolfin, 11 years ago

Status: newpending

comment:5 by SF/buddha_, 11 years ago

Status: pendingclosed

comment:6 by SF/buddha_, 11 years ago

Ah, sorry, forgot about this patch item totally. It's already committed to the trunk (r33087) and branch-0-12-0 (It got there too when it was branched from the trunk in r33159). Closing as accepted.

comment:7 by digitall, 15 months ago

Component: Engine: Cine
Note: See TracTickets for help on using tickets.