Opened 13 years ago

Closed 13 years ago

Last modified 22 months ago

#8793 closed patch

KYRA: HoF missing talkie credits and demo support

Reported by: athrxx Owned by: lordhoto
Priority: normal Component: Engine: Kyra
Keywords: Cc:
Game: Kyrandia 2

Description

This patch implements the missing credits screen for the talkie version. It might be worth trying to merge the scroll text code for kyra1 and kyra2, but that's just a thought.

The patch also adds support for the non interactive demo. For the scrolling pages in the fisher scene I changed the way in which page memory is allocated. If this is not appreciated I'd have to come up whith another way of doing this.

The kyradat tool patch will add an offset entry for a table that contains mainly frame numbers for the icon shapes in the fisher scene.

Florian

Ticket imported from: #1885629. Ticket imported from: patches/898.

Attachments (2)

hofCDCreditsAndDemo.patch (29.2 KB ) - added by athrxx 13 years ago.
KYRA: HoF missing CD credits and demo support
createKyradat(demoOffsetEntry).patch (2.3 KB ) - added by athrxx 13 years ago.

Download all attachments as: .zip

Change History (9)

by athrxx, 13 years ago

Attachment: hofCDCreditsAndDemo.patch added

KYRA: HoF missing CD credits and demo support

comment:1 by athrxx, 13 years ago

File Added: createKyradat(demoOffsetEntry).patch

comment:2 by athrxx, 13 years ago

Owner: set to lordhoto

comment:3 by lordhoto, 13 years ago

I just wonder about one thing why is the _pagePtrs allocation changed here? Is it because of the way copyPageMemory is used?

comment:4 by athrxx, 13 years ago

Yes, this is for the demo only (look at seq_scrollPage() in sequences_v2.cpp). This is some weird code.

comment:5 by lordhoto, 13 years ago

Status: newclosed

comment:6 by lordhoto, 13 years ago

Hm I see that really looks like we have to change it then, since with the current way its usually easier to check out of bounds writing with memory checkers, but well...

Committed with some minor formatting fixes and removed addition of _configTextspeed from KyraEngine_v2, since it wasn't used at all. Also bumped kyra.dat version, since new entries are included.

comment:7 by digitall, 22 months ago

Component: Engine: Kyra
Game: Kyrandia 2
Note: See TracTickets for help on using tickets.