#8794 closed patch
Two different fixes for the same NASM warnings
| Reported by: | eriktorbjorn | Owned by: | eriktorbjorn |
|---|---|---|---|
| Priority: | normal | Component: | --Other-- |
| Version: | Keywords: | ||
| Cc: | Game: |
Description
The latest version of NASM (2.01) produces lots and lots of warnings about lines with only a label, and no colon at the end. The colon is supposed to be optional, and earlier versions didn't warn me about it.
There are two possible fixes:
1) Add the "missing" colons. 2) Add -w-orphan-labels to NASMFLAGS
Strangely enough, we already do the latter. But only for MinGW and CygWin. That's one reason why I'm uncertain which is the preferred fix.
Ticket imported from: #1885901. Ticket imported from: patches/899.
Attachments (2)
Change History (15)
by , 16 years ago
| Attachment: | nasm1.diff added |
|---|
comment:2 by , 16 years ago
| Summary: | Two different fixes for NASM warnings → Two different fixes for the same NASM warnings |
|---|
comment:3 by , 16 years ago
IMO it would be cleanest to add the colons. But maybe there is indeed a reason they are missing? Kirben, does the first patch work under Windows?
Might also want to ask Eugene.
comment:4 by , 16 years ago
| Owner: | set to |
|---|
comment:5 by , 16 years ago
Compiling a Windows build under mingw still works fine, with the nasm1.diff patch applied.
comment:7 by , 16 years ago
| Owner: | changed from to |
|---|
comment:8 by , 16 years ago
| Owner: | changed from to |
|---|
comment:9 by , 16 years ago
I would vote for fix 1. Colons are the watchdog for further supported opcodes which could coincidentally match the label names.
Also I have a long time concerns that we still use other x86 ASM fixes in our code, especially in MT-32 which has to keep the code twice(!) in gcc and MSVC syntaxes. It would be really nice if someone would translate that code to NASM syntax.
comment:12 by , 16 years ago
| Status: | new → closed |
|---|
comment:13 by , 5 years ago
| Component: | → --Other-- |
|---|
Patch implementing the first fix