#8729 closed patch
Small enhancements in lookupFile
| Reported by: | jvprat | Owned by: | SF/david_corrales |
|---|---|---|---|
| Priority: | normal | Component: | --Other-- |
| Version: | Keywords: | ||
| Cc: | Game: |
Description
I'm attaching a set of small patches around the lookupFile functions in common/fs. The first one is to clarify the semantics of these functions, since they use the "filename" parameter as a pattern which accepts globs. This patch renames the parameters and updates the documentation.
Ticket imported from: #1814434. Ticket imported from: patches/834.
Attachments (3)
Change History (9)
by , 17 years ago
| Attachment: | 1_rename_filename.patch added |
|---|
by , 17 years ago
| Attachment: | 2_match_case_insensitive.patch added |
|---|
comment:1 by , 17 years ago
by , 17 years ago
| Attachment: | 3_remove_redundant_parameter.patch added |
|---|
comment:2 by , 17 years ago
The third patch removes a redundant parameter in one of the functions. Since it's a member function, we already have the directory, we don't need it as a parameter. Another approach (that I think would make sense) would be to make these functions static, since they don't need to be applied over a filesystem node. File Added: 3_remove_redundant_parameter.patch
comment:3 by , 17 years ago
| Owner: | set to |
|---|
comment:4 by , 17 years ago
Makes sense to me. In particular, I like that it *finally* fixes the indention in common/fs.cpp (I complained about that several times already ;-). David, please have a look, too, and if you are happy, commit this.
comment:5 by , 17 years ago
| Status: | new → closed |
|---|
comment:6 by , 5 years ago
| Component: | → --Other-- |
|---|
This second patch makes the match case insensitive, which I think makes sense because (as I understand it) the rest of filesystem operations are done in a case insensitive way. File Added: 2_match_case_insensitive.patch