Opened 12 years ago

Closed 12 years ago

Last modified 11 months ago

#8729 closed patch

Small enhancements in lookupFile

Reported by: jvprat Owned by: SF/david_corrales
Priority: normal Component: --Other--
Keywords: Cc:
Game:

Description

I'm attaching a set of small patches around the lookupFile functions in common/fs. The first one is to clarify the semantics of these functions, since they use the "filename" parameter as a pattern which accepts globs. This patch renames the parameters and updates the documentation.

Ticket imported from: #1814434. Ticket imported from: patches/834.

Attachments (3)

1_rename_filename.patch (4.7 KB ) - added by jvprat 12 years ago.
2_match_case_insensitive.patch (719 bytes ) - added by jvprat 12 years ago.
3_remove_redundant_parameter.patch (1.9 KB ) - added by jvprat 12 years ago.

Download all attachments as: .zip

Change History (9)

by jvprat, 12 years ago

Attachment: 1_rename_filename.patch added

by jvprat, 12 years ago

comment:1 by jvprat, 12 years ago

This second patch makes the match case insensitive, which I think makes sense because (as I understand it) the rest of filesystem operations are done in a case insensitive way.
File Added: 2_match_case_insensitive.patch

comment:2 by jvprat, 12 years ago

The third patch removes a redundant parameter in one of the functions. Since it's a member function, we already have the directory, we don't need it as a parameter. Another approach (that I think would make sense) would be to make these functions static, since they don't need to be applied over a filesystem node.
File Added: 3_remove_redundant_parameter.patch

comment:3 by fingolfin, 12 years ago

Owner: set to SF/david_corrales

comment:4 by fingolfin, 12 years ago

Makes sense to me. In particular, I like that it *finally* fixes the indention in common/fs.cpp (I complained about that several times already ;-).
David, please have a look, too, and if you are happy, commit this.

comment:5 by SF/david_corrales, 12 years ago

Status: newclosed

comment:6 by digitall, 11 months ago

Component: --Other--
Note: See TracTickets for help on using tickets.