Opened 12 years ago

Closed 12 years ago

Last modified 11 months ago

#8730 closed patch

Unify the way to report unknown versions of games

Reported by: jvprat Owned by: sev-
Priority: normal Component: --Other--
Keywords: Cc:
Game:

Description

The attached patch puts in a function the code that lets the user know that this version of the game is unknown, and it shows useful information to detect it, so it can also be used from the fallback detection functions. Otherwise, each custom fallback function should have its own way to report unknown versions.

Ticket imported from: #1814831. Ticket imported from: patches/835.

Attachments (1)

ADunknown.patch (3.5 KB ) - added by jvprat 12 years ago.

Download all attachments as: .zip

Change History (6)

by jvprat, 12 years ago

Attachment: ADunknown.patch added

comment:1 by sev-, 12 years ago

Owner: set to sev-

comment:2 by fingolfin, 12 years ago

Looks good to me. The code should be improved eventually (see also the TODO in reportUnknown), but factoring it out is a good start. Eugene, can this be applied?

comment:3 by sev-, 12 years ago

Thanks, it looks reasonable. Committed to SVN

comment:4 by sev-, 12 years ago

Status: newclosed

comment:5 by digitall, 11 months ago

Component: --Other--
Note: See TracTickets for help on using tickets.