Opened 12 years ago

Closed 12 years ago

Last modified 12 months ago

#8700 closed patch

GUI: Enlarge some labels in the themes

Reported by: jvprat Owned by: sev-
Priority: normal Component: GUI
Keywords: Cc:
Game:

Description

The attached patch enlarges the horizontal area of some widgets to cover the whole parent's width. This is needed to allow translations (whose messages can be longer than the English versions), since the current longitudes are hardcoded for the current messages/fonts.

I've tried both classic and modern themes in 1x, 2x and 3x modes. The only one that doesn't behave well is modern with 1x. I don't understand why (it's like it isn't reading my changes), but it's showing the old short longitudes. If you find what's wrong with it I'd appreciate to know it. Thanks!

Ticket imported from: #1742050. Ticket imported from: patches/805.

Attachments (2)

themes_labels.patch (5.4 KB ) - added by jvprat 12 years ago.
themes_labels_default.patch (3.6 KB ) - added by jvprat 12 years ago.

Download all attachments as: .zip

Change History (7)

by jvprat, 12 years ago

Attachment: themes_labels.patch added

comment:1 by sev-, 12 years ago

Owner: set to sev-

by jvprat, 12 years ago

Attachment: themes_labels_default.patch added

comment:2 by jvprat, 12 years ago

Ok, I found the problem with 1x mode. I didn't fully understand the way themes work. It seems that in 1x mode, it reuses stuff from the default theme, so here I attach the needed modifications on the default theme.
File Added: themes_labels_default.patch

comment:3 by sev-, 12 years ago

Status: newclosed

comment:4 by sev-, 12 years ago

Thank you, committed as is.

comment:5 by digitall, 12 months ago

Component: GUI
Note: See TracTickets for help on using tickets.