Opened 12 years ago

Closed 11 years ago

Last modified 12 months ago

#8699 closed patch (outdated)

GUI: Blur dialog shading

Reported by: jvprat Owned by: lordhoto
Priority: normal Component: GUI
Keywords: Cc:
Game:

Description

I'm attaching a patch to support the blur shading I described here: http://forums.scummvm.org/viewtopic.php?t=4052

I've optimized it mainly by reworking the algorithm. I've also tried to work with a RGB surface and not having to do the conversion while blurring, but it doesn't seem to have a noticeable performance enhancement. Let me know if you have further ideas on how to improve it.

BTW I'm attaching two versions of it:

blur.patch: It just adds the new effect

blur-mix.patch: It reworks the way filters are used. With it you can use all the filters, just have to set their parameters. (The modified theme uses luminance, dimming and blurring as an example, I like how it looks :)

Ticket imported from: #1742028. Ticket imported from: patches/804.

Attachments (2)

blur.patch (7.1 KB ) - added by jvprat 12 years ago.
blur-mix.patch (9.7 KB ) - added by jvprat 12 years ago.

Download all attachments as: .zip

Change History (12)

by jvprat, 12 years ago

Attachment: blur.patch added

by jvprat, 12 years ago

Attachment: blur-mix.patch added

comment:1 by jvprat, 12 years ago

File Added: blur-mix.patch

comment:2 by jvprat, 12 years ago

Summary: Blur dialog shadingGUI: Blur dialog shading

comment:3 by lordhoto, 12 years ago

I'll take a look at this when I find some time.

comment:4 by lordhoto, 12 years ago

Owner: set to lordhoto

comment:5 by fingolfin, 12 years ago

Any news on this, LordHoto?

Anyway: The current GUI code seems to be rather unoptimized to me. Maybe we should first work on that (might involve using the framebuffer, and using different code paths for 8bit and 16bit mode in some spots)...

comment:6 by lordhoto, 12 years ago

Just remembered yesterday about this patch again, to be honest, so no news :-)

I'm currently planning to rework the modern theme renderer anyway, so we could allow more eye candy, I'm not sure if I'll take a look at this before or after that.

comment:7 by jvprat, 12 years ago

I'm interested in this theme renderer rework, so let me know if I can do something to help. I thought about implementing some kind of grid layout to automatically calculate aligned positions for widgets. Also, while working on the translation patches, I noted that some strings were requested twice and I got the feeling that some things are drawn more times than the necessary.

comment:8 by lordhoto, 11 years ago

Since we finally reworked our theme renderer, I'll close this one as out of date. Feel free to reopen it, when you updated it to the current code.

comment:9 by lordhoto, 11 years ago

Resolution: outdated
Status: newclosed

comment:10 by digitall, 12 months ago

Component: GUI
Note: See TracTickets for help on using tickets.