Opened 14 years ago

Closed 14 years ago

Last modified 15 months ago

#8483 closed patch

Possible fix for Kyra CD intro glitch

Reported by: eriktorbjorn Owned by: lordhoto
Priority: normal Component: Engine: Kyra
Keywords: Cc:
Game:

Description

I had a sudden flash of inspiration about the Kyra CD intro glitch, where the image goes almost black at the beginning of the "tree2" movie.

Since each new frame is XOR:ed with whatever was there before, the screen going black would mean that the decoded frame data looks just like what's already in the destination buffer. So to keep that from happening, all we have to do is to make sure the buffer is cleared first.

I don't know if this patch represents the correct way of doing that, though. But it does fix the aforementioned glitch for me.

Ticket imported from: #1350387. Ticket imported from: patches/588.

Attachments (1)

kyra-cd-intro.diff (595 bytes ) - added by eriktorbjorn 14 years ago.
Patch against a November 7 CVS snapshot

Download all attachments as: .zip

Change History (8)

by eriktorbjorn, 14 years ago

Attachment: kyra-cd-intro.diff added

Patch against a November 7 CVS snapshot

comment:1 by eriktorbjorn, 14 years ago

Owner: set to lordhoto

comment:2 by fingolfin, 14 years ago

LordHoto, you took this item -- now, is there any reason you didn't just apply it? If so, please add them to this tracker item.

comment:3 by eriktorbjorn, 14 years ago

Actually, I assigned it to him, then spoke to him in private. He promised to take a closer look in a few days, when he was less busy.

I'm convinced that I've found the reason for the CD intro glitch, but I have no idea if this is the correct fix for it. It might break the floppy version, which I do not have myself so I can't test.

comment:4 by lordhoto, 14 years ago

Status: newclosed

comment:5 by lordhoto, 14 years ago

ok commited, but with one change: it clears the screen page only if it is a CD version, since if it would be done like you did it we have the same glitch with the floppy version. thanks

comment:6 by lordhoto, 14 years ago

ok commited, but with one change: it clears the screen page only if it is a CD version, since if it would be done like you did it we have the same glitch with the floppy version. thanks

comment:7 by digitall, 15 months ago

Component: Engine: Kyra
Note: See TracTickets for help on using tickets.