#8484 closed patch
KYRA: Chat and various fixes
| Reported by: | vinterstum | Owned by: | lordhoto |
|---|---|---|---|
| Priority: | normal | Component: | Engine: Kyra |
| Version: | Keywords: | ||
| Cc: | Game: |
Description
Implements the cmd_characterSay() opcode and numerous supporting functions. Also does a few various fixes, and modifies the scene animations to better mesh with the rest of the system.
Ticket imported from: #1350510. Ticket imported from: patches/589.
Attachments (3)
Change History (15)
by , 18 years ago
| Attachment: | kyra_chat_plus_plus.patch added |
|---|
comment:1 by , 18 years ago
| Owner: | set to |
|---|
comment:2 by , 18 years ago
LordHoto, you took this item -- now, is there any reason you didn't just apply it? If so, please add them to this tracker item.
comment:3 by , 18 years ago
Well I had no time but I wanted to look at it first, before commiting anything. So maybe it will be accepted just as is.
comment:4 by , 18 years ago
Oh no no, absolutley no reason for undue hurry :-). It's all my fault, I thought that lordhoto had taken this item by himself and was wondering why no message appeared -- sorry, should have checked more carefully!. As long as I know this item is "in progress", and that comments will be posted here (and not just in private emails), I have absolutley no problem waiting a couple days/weeks/months for it to be resolved (the submitter might, but that's another thing ;-).
comment:6 by , 18 years ago
Well back to on topic now:
- there are some bugs with the drawposition of the sprites as it looks - also there is a force scene change that is not used, it is only not done because out of some missing functionallity. - also there is some debug output, maybe you should show it only at a special debuglevel (maybe 1 or 2 or something) - also cmd_characterSays looks strange since the strings compared there are looking odd, like binary data
I think you should take a look at it, before it gets commited. But nice work.
comment:7 by , 18 years ago
(to repeat stuff from IRC, for the record :)
- The drawing issue (a width issue) is due to Screen::copyRegion() which currently expects the width parameter to be the actual width, and not 1/8 of the width (as in the original engine). Some of our other code expects it to be like that, some of it expects it to be like the original. - The scene change wasn't mean to be a permanent addition :) - The debug output was an oversight, will correct it. - Yeah, the strings in cmd_characterSays are odd. I've double and tripplechecked them though. As you speculated when I originally mentioned it, they might be relevant to the Japanese version only.
comment:8 by , 18 years ago
Well if it is only used for the japanese version I think it would be better to leave it out since we do not support it.
by , 18 years ago
| Attachment: | kyra_chat_plus_plus_v2.patch added |
|---|
comment:9 by , 18 years ago
V2: * Fixes sprite drawing * Hands mouse drawing back to OSystem * Adds support for cmd_message() and supporting function * Added various animation-related opcodes * Added a function which does more room initialization (without the palette stuff, which doesn't seem necessary). * Probably more I've forgotten.
comment:11 by , 18 years ago
| Status: | new → closed |
|---|
comment:12 by , 5 years ago
| Component: | → Engine: Kyra |
|---|
KYRA: chat and sundry