Opened 21 years ago

Closed 21 years ago

#838 closed defect (fixed)

SAM: Sound effects cut off in non-interactive demo

Reported by: eriktorbjorn Owned by: fingolfin
Priority: normal Component: Engine: SCUMM
Version: Keywords:
Cc: Game: Sam and Max

Description

In the non-interactive Sam & Max demo, the sound effects (the narrator voice) are cut off. It's especially noticeable with the one at the end.

As far as I can tell, this is because Sound::isSoundRunning() calls _scumm->_mixer->stopID(sound). It's been doing that since revision 1.98 of sound.cpp. Does anyone know why it was added? The commit message just says "cleanup".

Ticket imported from: #747396. Ticket imported from: bugs/838.

Change History (3)

comment:1 by eriktorbjorn, 21 years ago

Owner: set to fingolfin

comment:2 by fingolfin, 21 years ago

Resolution: fixed
Status: newclosed

comment:3 by fingolfin, 21 years ago

I have not the slightest clue how that got there. I remember that cleanup session, but not ever putting that there (i.e. of course I put it there according to the cvs log, I just can't remember why I would have done that, not even for temporary testing....)

ah well, enough of the lame excuses, I removed it again :-) Thanks for spotting this.

Note: See TracTickets for help on using tickets.