Opened 16 years ago

Closed 16 years ago

Last modified 10 months ago

#8262 closed patch

ALL: Two small fixes for the aspect ratio correction

Reported by: eriktorbjorn Owned by: fingolfin
Priority: normal Component: Graphics
Keywords: Cc:
Game: Indiana Jones 4

Description

These patches should be perfectly safe, so please
consider for 0.5.0.

The first patch takes aspect ratio correction into
consideration when clearing the top of the screen when
it's shaking. The only place I know where this makes
any difference is during the end of FOA. Without the
patch there's sometimes a line at the top that isn't
cleared when the rest of the screen is.

The second patch simply makes makeRectStretchable() a
no-op when the "fast and ugly" aspect ratio correction
is enabled.

Ticket imported from: #774556. Ticket imported from: patches/367.

Attachments (3)

shake-aspect.diff (1.3 KB) - added by eriktorbjorn 16 years ago.
Patch against a July 19 CVS snapshot
stretchable.diff (583 bytes) - added by eriktorbjorn 16 years ago.
Patch against a July 19 CVS snapshot
alignment.diff (2.1 KB) - added by eriktorbjorn 16 years ago.
Experimental patch against a July 20 CVS snapshot

Download all attachments as: .zip

Change History (6)

Changed 16 years ago by eriktorbjorn

Attachment: shake-aspect.diff added

Patch against a July 19 CVS snapshot

Changed 16 years ago by eriktorbjorn

Attachment: stretchable.diff added

Patch against a July 19 CVS snapshot

Changed 16 years ago by eriktorbjorn

Attachment: alignment.diff added

Experimental patch against a July 20 CVS snapshot

comment:1 Changed 16 years ago by eriktorbjorn

I'm attaching yet another patch, though I can't test if it
really does what it's supposed to do.

It changes makeRectStretchable() in the "fast and nice" case
so that the rectangle starts on an even X coordinate, and
its width is even as well.

I'm hoping that the first change will ensure that memory
access is aligned. The second change eliminates a special
case in the interpolation function.

comment:2 Changed 16 years ago by fingolfin

Owner: set to fingolfin
Status: newclosed

comment:3 Changed 10 months ago by digitall

Component: Graphics
Game: Indiana Jones 4
Note: See TracTickets for help on using tickets.